From: David Rientjes <rientjes@google.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, Cristoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 3/4] slab: move FULL state transition to an initcall
Date: Thu, 21 Jun 2012 01:01:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206210100260.31077@chino.kir.corp.google.com> (raw)
In-Reply-To: <1340225959-1966-4-git-send-email-glommer@parallels.com>
On Thu, 21 Jun 2012, Glauber Costa wrote:
> During kmem_cache_init_late(), we transition to the LATE state,
> and after some more work, to the FULL state, its last state
>
> This is quite different from slub, that will only transition to
> its last state (previously SYSFS), in a (late)initcall, after a lot
> more of the kernel is ready.
>
> This means that in slab, we have no way to taking actions dependent
> on the initialization of other pieces of the kernel that are supposed
> to start way after kmem_init_late(), such as cgroups initialization.
>
> To achieve more consistency in this behavior, that patch only
> transitions to the UP state in kmem_init_late. In my analysis,
> setup_cpu_cache() should be happy to test for >= UP, instead of
> == FULL. It also has passed some tests I've made.
>
> We then only mark FULL state after the reap timers are in place,
> meaning that no further setup is expected.
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> Acked-by: Christoph Lameter <cl@linux.com>
> CC: Pekka Enberg <penberg@cs.helsinki.fi>
> CC: David Rientjes <rientjes@google.com>
Acked-by: David Rientjes <rientjes@google.com>
[ Might want to fix your address book in your email client because
Christoph's name is misspelled in the cc list. ]
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-21 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 20:59 [PATCH 0/4] cache-specific changes for memcg (preparation) Glauber Costa
2012-06-20 20:59 ` [PATCH 1/4] slab: rename gfpflags to allocflags Glauber Costa
2012-06-21 7:53 ` David Rientjes
2012-06-20 20:59 ` [PATCH 2/4] Wipe out CFLGS_OFF_SLAB from flags during initial slab creation Glauber Costa
2012-06-21 7:59 ` David Rientjes
2012-06-20 20:59 ` [PATCH 3/4] slab: move FULL state transition to an initcall Glauber Costa
2012-06-21 8:01 ` David Rientjes [this message]
2012-07-02 10:57 ` Pekka Enberg
2012-06-20 20:59 ` [PATCH 4/4] don't do __ClearPageSlab before freeing slab page Glauber Costa
2012-06-21 8:04 ` David Rientjes
2012-06-21 8:13 ` Glauber Costa
2012-06-21 11:04 ` Kamezawa Hiroyuki
2012-06-21 11:14 ` Glauber Costa
2012-06-21 20:24 ` Glauber Costa
2012-07-03 18:42 ` Christoph Lameter
2012-07-03 18:40 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2012-06-14 12:17 [PATCH 0/4] Proposed slab patches as basis for memcg Glauber Costa
2012-06-14 12:17 ` [PATCH 3/4] slab: move FULL state transition to an initcall Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206210100260.31077@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox