From: David Rientjes <rientjes@google.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, Cristoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 2/4] Wipe out CFLGS_OFF_SLAB from flags during initial slab creation
Date: Thu, 21 Jun 2012 00:59:18 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206210055360.31077@chino.kir.corp.google.com> (raw)
In-Reply-To: <1340225959-1966-3-git-send-email-glommer@parallels.com>
On Thu, 21 Jun 2012, Glauber Costa wrote:
> CFLGS_OFF_SLAB is not a valid flag to be passed to cache creation.
> If we are duplicating a cache - support added in a future patch -
> we will rely on the flags it has stored in itself. That may include
> CFLGS_OFF_SLAB.
>
> So it is better to clean this flag at cache creation.
>
I think this should be folded into the patch that allows cache
duplication, it doesn't make sense to apply right now because
CFLGS_OFF_SLAB is internal to mm/slab.c and it's not going to be passing
this to kmem_cache_create() itself yet.
Also, do we care that cache_estimate() uses a formal of type int for flags
when CFLGS_OFF_SLAB is unsigned long?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-21 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 20:59 [PATCH 0/4] cache-specific changes for memcg (preparation) Glauber Costa
2012-06-20 20:59 ` [PATCH 1/4] slab: rename gfpflags to allocflags Glauber Costa
2012-06-21 7:53 ` David Rientjes
2012-06-20 20:59 ` [PATCH 2/4] Wipe out CFLGS_OFF_SLAB from flags during initial slab creation Glauber Costa
2012-06-21 7:59 ` David Rientjes [this message]
2012-06-20 20:59 ` [PATCH 3/4] slab: move FULL state transition to an initcall Glauber Costa
2012-06-21 8:01 ` David Rientjes
2012-07-02 10:57 ` Pekka Enberg
2012-06-20 20:59 ` [PATCH 4/4] don't do __ClearPageSlab before freeing slab page Glauber Costa
2012-06-21 8:04 ` David Rientjes
2012-06-21 8:13 ` Glauber Costa
2012-06-21 11:04 ` Kamezawa Hiroyuki
2012-06-21 11:14 ` Glauber Costa
2012-06-21 20:24 ` Glauber Costa
2012-07-03 18:42 ` Christoph Lameter
2012-07-03 18:40 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206210055360.31077@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox