From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx202.postini.com [74.125.245.202]) by kanga.kvack.org (Postfix) with SMTP id F30366B0071 for ; Thu, 21 Jun 2012 01:13:15 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so2008138pbb.14 for ; Wed, 20 Jun 2012 22:13:15 -0700 (PDT) Date: Wed, 20 Jun 2012 22:13:12 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH] mm/buddy: get the allownodes for dump at once In-Reply-To: <20120621044725.GA20379@shangw> Message-ID: References: <1339662910-25774-1-git-send-email-shangw@linux.vnet.ibm.com> <20120621044725.GA20379@shangw> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Gavin Shan Cc: linux-mm@kvack.org, minchan@kernel.org, mgorman@suse.de, akpm@linux-foundation.org On Thu, 21 Jun 2012, Gavin Shan wrote: > I'm not sure it's the possible to resolve the concerns with "static" here > since "allownodes" will be cleared for each call to show_free_areas(). > > static nodemask_t allownodes; > There's nothing protecting concurrent access to it. This function certainly isn't in a performance sensitive path so I would be inclined to just leave it as is. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org