From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-mm@kvack.org
Subject: [patch] mm, oom: do not schedule if current has been killed
Date: Mon, 18 Jun 2012 18:08:03 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1206181807060.13281@chino.kir.corp.google.com> (raw)
The oom killer currently schedules away from current in an
uninterruptible sleep if it does not have access to memory reserves.
It's possible that current was killed because it shares memory with the
oom killed thread or because it was killed by the user in the interim,
however.
This patch only schedules away from current if it does not have a pending
kill, i.e. if it does not share memory with the oom killed thread. It's
possible that it will immediately retry its memory allocation and fail,
but it will immediately be given access to memory reserves if it calls
the oom killer again.
This prevents the delay of memory freeing when threads that share memory
with the oom killed thread get unnecessarily scheduled.
Signed-off-by: David Rientjes <rientjes@google.com>
---
mm/oom_kill.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -749,7 +749,7 @@ out:
* Give "p" a good chance of killing itself before we
* retry to allocate memory unless "p" is current
*/
- if (killed && !test_thread_flag(TIF_MEMDIE))
+ if (killed && !fatal_signal_pending(current))
schedule_timeout_uninterruptible(1);
}
@@ -765,6 +765,6 @@ void pagefault_out_of_memory(void)
out_of_memory(NULL, 0, 0, NULL, false);
clear_system_oom();
}
- if (!test_thread_flag(TIF_MEMDIE))
+ if (!fatal_signal_pending(current))
schedule_timeout_uninterruptible(1);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-06-19 1:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 1:08 David Rientjes [this message]
2012-06-19 1:57 ` Kamezawa Hiroyuki
2012-06-19 2:23 ` David Rientjes
2012-06-19 2:31 ` [patch v2] " David Rientjes
2012-06-19 2:51 ` Kamezawa Hiroyuki
2012-06-19 6:03 ` KOSAKI Motohiro
2012-06-19 6:26 ` David Rientjes
2012-06-19 17:32 ` KOSAKI Motohiro
2012-06-19 18:59 ` David Rientjes
2012-06-19 19:29 ` KOSAKI Motohiro
2012-06-19 13:55 ` Oleg Nesterov
2012-06-19 20:24 ` David Rientjes
2012-06-19 20:58 ` [patch v3] " David Rientjes
2012-06-19 21:39 ` KOSAKI Motohiro
2012-06-20 0:38 ` Kamezawa Hiroyuki
2012-06-21 1:23 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1206181807060.13281@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox