linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: cl@linux.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: fix protection column misplacing in /proc/zoneinfo
Date: Mon, 11 Jun 2012 13:52:54 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1206111350550.6389@chino.kir.corp.google.com> (raw)
In-Reply-To: <CAHGf_=rbss0RsoFn7NZ7oFCpCZuEYkPDXaHSW4KHg=Vu8703xA@mail.gmail.com>

On Mon, 11 Jun 2012, KOSAKI Motohiro wrote:

> > We do, and I think it would be a shame to break anything parsing the way
> > that this file has been written for the past several years for something
> > as aesthetical as this.
> 
> How do you parsing?
> 
> Several years, some one added ZVC stat. therefore, hardcoded line
> number parsing never work anyway. And in the other hand, if you are
> parsing, field
> name, my patch doesn't break anything.
> 

Yeah, your patch doesn't break me because I'm parsing by field name but I 
feel it would be a shame for it to break anyone else that may not be doing 
it that way.  The set of users in the world who are parsing /proc/zoneinfo 
who may or may not do crazy things is not fully represented on this 
thread, so I don't feel it's worth it.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-06-11 20:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-11 13:50 kosaki.motohiro
2012-06-11 14:02 ` Christoph Lameter
2012-06-11 14:31   ` KOSAKI Motohiro
2012-06-11 14:40     ` Christoph Lameter
2012-06-11 14:58       ` KOSAKI Motohiro
2012-06-11 20:37     ` David Rientjes
2012-06-11 20:48       ` KOSAKI Motohiro
2012-06-11 20:52         ` David Rientjes [this message]
2012-06-11 21:04         ` Christoph Lameter
2012-06-11 21:19           ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1206111350550.6389@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=cl@linux.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox