From: Christoph Lameter <cl@linux.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: kosaki.motohiro@gmail.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andrew Morton <akpm@google.com>,
Dave Jones <davej@redhat.com>, Mel Gorman <mgorman@suse.de>,
stable@vger.kernel.org, hughd@google.com, sivanich@sgi.com,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
andi@firstfloor.org
Subject: Re: [PATCH 0/6] mempolicy memory corruption fixlet
Date: Wed, 30 May 2012 13:34:21 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1205301328550.31768@router.home> (raw)
In-Reply-To: <CA+55aFzoVQ29C-AZYx=G62LErK+7HuTCpZhvovoyS0_KTGGZQg@mail.gmail.com>
On Wed, 30 May 2012, Linus Torvalds wrote:
> On Wed, May 30, 2012 at 2:02 AM, <kosaki.motohiro@gmail.com> wrote:
> >
> > So, I think we should reconsider about shared mempolicy completely.
>
> Quite frankly, I'd prefer that approach. The code is subtle and
> horribly bug-fraught, and I absolutely detest the way it looks too.
> Reading your patches was actually somewhat painful.
It is so bad mostly because the integration of shared memory policies with
cpusets is not really working. Using either in isolation is ok especially
shared mempolicies do not play well with cpusets.
> If we could just remove the support for it entirely, that would be
> *much* preferable to continue working with this code.
Well shm support needs memory policies to spread data across nodes etc.
AFAICT support was put in due to requirements to support large database
vendors (oracle). Andi?
Its not going to be easy to remove.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-30 18:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 9:02 kosaki.motohiro
2012-05-30 9:02 ` [PATCH 1/6] Revert "mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy linkages" kosaki.motohiro
2012-05-30 19:17 ` Christoph Lameter
2012-05-30 19:39 ` KOSAKI Motohiro
2012-05-30 19:44 ` Christoph Lameter
2012-05-31 6:49 ` KOSAKI Motohiro
2012-05-30 9:02 ` [PATCH 2/6] mempolicy: Kill all mempolicy sharing kosaki.motohiro
2012-05-30 19:41 ` Christoph Lameter
2012-05-30 19:46 ` KOSAKI Motohiro
2012-05-30 19:48 ` Andi Kleen
2012-05-30 20:31 ` Andi Kleen
2012-05-30 20:58 ` KOSAKI Motohiro
2012-05-30 9:02 ` [PATCH 3/6] mempolicy: fix a race in shared_policy_replace() kosaki.motohiro
2012-05-30 9:02 ` [PATCH 4/6] mempolicy: fix refcount leak in mpol_set_shared_policy() kosaki.motohiro
2012-05-30 9:02 ` [PATCH 5/6] mempolicy: fix a memory corruption by refcount imbalance in alloc_pages_vma() kosaki.motohiro
2012-05-30 20:37 ` Andi Kleen
2012-05-30 9:02 ` [PATCH 6/6] MAINTAINERS: Added MEMPOLICY entry kosaki.motohiro
2012-05-30 19:27 ` Christoph Lameter
2012-05-30 18:26 ` [PATCH 0/6] mempolicy memory corruption fixlet Linus Torvalds
2012-05-30 18:34 ` Christoph Lameter [this message]
2012-05-30 18:46 ` Andi Kleen
2012-05-30 18:50 ` Christoph Lameter
2012-05-30 19:32 ` Andi Kleen
2012-05-30 19:42 ` Christoph Lameter
2012-05-30 19:52 ` Andi Kleen
2012-05-30 20:00 ` KOSAKI Motohiro
2012-05-30 21:22 ` Ben Hutchings
2012-05-30 21:25 ` KOSAKI Motohiro
2012-05-30 19:54 ` KOSAKI Motohiro
2012-05-30 20:10 ` Andi Kleen
2012-05-30 20:16 ` KOSAKI Motohiro
2012-06-01 0:45 ` david
2012-06-01 13:51 ` Christoph Lameter
2012-06-01 19:31 ` david
2012-06-01 19:37 ` KOSAKI Motohiro
2012-06-05 19:02 ` Linus Torvalds
2012-06-05 19:17 ` Andrew Morton
2012-06-06 19:10 ` KOSAKI Motohiro
2012-05-30 19:03 ` Linus Torvalds
2012-05-30 20:10 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1205301328550.31768@router.home \
--to=cl@linux.com \
--cc=akpm@google.com \
--cc=andi@firstfloor.org \
--cc=davej@redhat.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=sivanich@sgi.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox