From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx105.postini.com [74.125.245.105]) by kanga.kvack.org (Postfix) with SMTP id C799F6B0068 for ; Tue, 29 May 2012 10:20:20 -0400 (EDT) Date: Tue, 29 May 2012 09:20:16 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH v3 05/28] memcg: Reclaim when more than one page needed. In-Reply-To: Message-ID: References: <1337951028-3427-1-git-send-email-glommer@parallels.com> <1337951028-3427-6-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com, Tejun Heo , Li Zefan , Greg Thelen , Suleiman Souhlal , Michal Hocko , Johannes Weiner , devel@openvz.org, David Rientjes On Tue, 29 May 2012, Christoph Lameter wrote: > > * unlikely to succeed so close to the limit, and we fall back > > * to regular pages anyway in case of failure. > > */ > > - if (nr_pages == 1 && ret) > > + if (nr_pages <= (PAGE_SIZE << PAGE_ALLOC_COSTLY_ORDER) && ret) { Should this not be nr_pages <= 1 << PAGE_ALLOC_COSTLY_ORDER -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org