From: David Rientjes <rientjes@google.com>
To: Christoph Lameter <cl@linux.com>
Cc: Glauber Costa <glommer@parallels.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH v2] slab+slob: dup name string
Date: Tue, 22 May 2012 20:55:53 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1205222048380.28165@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205220857380.17600@router.home>
On Tue, 22 May 2012, Christoph Lameter wrote:
> > [ v2: Also dup string for early caches, requested by David Rientjes ]
>
> kstrdups that early could cause additional issues. Its better to leave
> things as they were.
>
No, it's not, there's no reason to prevent caches created before
g_cpucache_up <= EARLY to be destroyed because it makes a patch easier to
implement and then leave that little gotcha as an undocumented treasure
for someone to find when they try it later on.
I hate consistency patches like this because it could potentially fail a
kmem_cache_create() from a sufficiently long cache name when it wouldn't
have before, but I'm not really concerned since kmem_cache_create() will
naturally be followed by kmem_cache_alloc() which is more likely to cause
the oom anyway. But it's just another waste of memory for consistency
sake.
This is much easier to do, just statically allocate the const char *'s
needed for the boot caches and then set their ->name's manually in
kmem_cache_init() and then avoid the kfree() in kmem_cache_destroy() if
the name is between &boot_cache_name[0] and &boot_cache_name[n].
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-23 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 9:51 Glauber Costa
2012-05-22 13:58 ` Christoph Lameter
2012-05-22 15:27 ` Glauber Costa
2012-05-22 17:18 ` Christoph Lameter
2012-05-23 3:55 ` David Rientjes [this message]
2012-05-23 9:25 ` Glauber Costa
2012-05-23 13:53 ` Christoph Lameter
2012-05-24 1:01 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1205222048380.28165@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox