From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx187.postini.com [74.125.245.187]) by kanga.kvack.org (Postfix) with SMTP id 1899D6B0044 for ; Mon, 21 May 2012 09:51:19 -0400 (EDT) Date: Mon, 21 May 2012 08:51:15 -0500 (CDT) From: Christoph Lameter Subject: Re: [RFC] Common code 00/12] Sl[auo]b: Common functionality V2 In-Reply-To: <4FBA0D25.8040203@parallels.com> Message-ID: References: <20120518161906.207356777@linux.com> <4FBA0D25.8040203@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: Pekka Enberg , linux-mm@kvack.org, David Rientjes , Matt Mackall , Joonsoo Kim , Alex Shi On Mon, 21 May 2012, Glauber Costa wrote: > While we're at it, can one of my patches for consistent name string handling > among caches be applied? > > Once you guys reach a decision about what is the best behavior: strdup'ing it > in all caches, or not strduping it for the slub, I can provide an updated > patch that also updates the slob accordingly. strduping is the safest approach. If slabs keep a pointer to string data around then slabs also need their private copy. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org