From: Christoph Lameter <cl@linux.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Matt Mackall <mpm@selenic.com>
Subject: Re: [RFC] SL[AUO]B common code 5/9] slabs: Common definition for boot state of the slab allocators
Date: Thu, 17 May 2012 09:16:28 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1205170914340.5144@router.home> (raw)
In-Reply-To: <4FB5065E.8020702@parallels.com>
On Thu, 17 May 2012, Glauber Costa wrote:
> > Why can this processing not be done when sysfs has just been initialized?
>
> If we can be 100 % sure that idr/ida is always initialized before sysfs, than
> yes, we can.
idr_init_cache() is run even before kmem_cache_init_late(). Have a look at
init/main.c. No need to muck with the bootup sequence.
> > The reason to use == is because we want things to happen only at a
> > particular stage of things. The == SYSFS means we will only do an action
> > if the slab system is fully functional. Such things will have to be
> > reevaluated if the number of states change.
>
> Yes, but you are actually arguing in my favor. "fully functional" means >=
> SYSFS, not == SYSFS.
That is only true if you add another state.
> If for whatever reordering people may decide doing another state is added, or
> this function is called later, that will fail
Then the assumptions that SYSFS is the final state is no longer true and
therefore the code needs to be inspected if this change affects anything.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-17 14:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 20:15 [RFC] SL[AUO]B common code 0/9] Sl[auo]b: Common functionality V1 Christoph Lameter
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 1/9] [slob] define page struct fields used in mm_types.h Christoph Lameter
2012-05-16 7:31 ` Glauber Costa
2012-05-16 14:26 ` Christoph Lameter
2012-05-16 15:38 ` Christoph Lameter
2012-05-17 9:41 ` Glauber Costa
2012-05-17 14:09 ` Christoph Lameter
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 2/9] [slab]: Use page struct fields instead of casting Christoph Lameter
2012-05-16 7:52 ` Glauber Costa
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 3/9] Extract common fields from struct kmem_cache Christoph Lameter
2012-05-16 7:59 ` Glauber Costa
2012-05-16 14:28 ` Christoph Lameter
2012-05-16 15:41 ` Christoph Lameter
[not found] ` <alpine.LFD.2.02.1205160943180.2249@tux.localdomain>
[not found] ` <alpine.DEB.2.00.1205160922520.25512@router.home>
[not found] ` <alpine.LFD.2.02.1205181221570.3899@tux.localdomain>
2012-05-18 13:57 ` Christoph Lameter
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 4/9] slabs: Extract common code for kmem_cache_create Christoph Lameter
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 5/9] slabs: Common definition for boot state of the slab allocators Christoph Lameter
2012-05-16 8:19 ` Glauber Costa
2012-05-16 14:31 ` Christoph Lameter
2012-05-17 9:38 ` Glauber Costa
2012-05-17 14:07 ` Christoph Lameter
2012-05-17 14:08 ` Glauber Costa
2012-05-17 14:16 ` Christoph Lameter [this message]
2012-05-17 14:19 ` Glauber Costa
2012-05-17 14:27 ` Christoph Lameter
2012-05-16 15:44 ` Christoph Lameter
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 6/9] slabs: Use a common mutex definition Christoph Lameter
2012-05-16 8:34 ` Glauber Costa
2012-05-16 14:32 ` Christoph Lameter
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 7/9] slabs: Move kmem_cache_create mutex handling to common code Christoph Lameter
2012-05-16 10:15 ` Glauber Costa
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 8/9] slabs: list addition move to slab_common Christoph Lameter
2012-05-16 10:09 ` Glauber Costa
2012-05-16 14:33 ` Christoph Lameter
2012-05-17 9:39 ` Glauber Costa
2012-05-17 14:09 ` Christoph Lameter
2012-05-14 20:15 ` [RFC] SL[AUO]B common code 9/9] slabs: Extract a common function for kmem_cache_destroy Christoph Lameter
2012-05-16 8:08 ` [RFC] SL[AUO]B common code 0/9] Sl[auo]b: Common functionality V1 Glauber Costa
2012-05-16 14:28 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1205170914340.5144@router.home \
--to=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox