Re: [RFC] SL[AUO]B common code 6/9] slabs: Use a common mutex definition

Glauber Costa
2012-05-16T08:36:12Z

On 05/15/2012 12:15 AM, Christoph Lameter wrote:
> Use the mutex definition from SLAB and make it the common way to take a sleeping lock.
>
> This has the effect of using a mutex instead of a rw semaphore for SLUB.

This is very good, IMHO.

> SLOB gains the use of a mutex for kmem_cache_create serialization.
> Not needed now but SLOB may acquire some more features later (like slabinfo
> / sysfs support) through the expansion of the common code that will
> need this.

Now, won't this hurt performance of the slob allocator, that seems to
gain its edge from its simplicity ?

But I'll let whoever cares comment on that. From where I stand:

> Signed-off-by: Christoph Lameter<cl@linux.com>
>
Reviewed-by: Glauber Costa <glommer@parallels.com>