linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Pravin B Shelar <pshelar@nicira.com>,
	penberg@kernel.org, mpm@selenic.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	jesse@nicira.com, abhide@nicira.com
Subject: Re: [PATCH v2] mm: Fix slab->page _count corruption.
Date: Tue, 15 May 2012 09:04:01 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1205150903320.6488@router.home> (raw)
In-Reply-To: <1337034892.8512.652.camel@edumazet-glaptop>

On Tue, 15 May 2012, Eric Dumazet wrote:

> > Following patch fixes it by moving page->_count out of cmpxchg_double
> > data. So that slub does no change it while updating slub meta-data in
> > struct page.
>
> I say again : Page is owned by slub, so get_page() or put_page() is not
> allowed ?

It is allowed since slab memory can be used for DMA.

> How is put_page() going to work with order-1 or order-2 allocations ?

It is always incrementing the page count of the head page.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-05-15 14:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 22:29 Pravin B Shelar
2012-05-14 22:34 ` Eric Dumazet
2012-05-15  0:13   ` Pravin Shelar
2012-05-15 14:04   ` Christoph Lameter [this message]
2012-05-16 17:49 ` Pravin Shelar
2012-05-16 17:51   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1205150903320.6488@router.home \
    --to=cl@linux.com \
    --cc=abhide@nicira.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jesse@nicira.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=pshelar@nicira.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox