linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Minchan Kim <minchan@kernel.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Nick Piggin <npiggin@gmail.com>, Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, Hugh Dickins <hughd@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC] propagate gfp_t to page table alloc functions
Date: Fri, 27 Apr 2012 03:43:14 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1204270340450.11866@chino.kir.corp.google.com> (raw)
In-Reply-To: <4F9A0360.3030900@kernel.org>

On Fri, 27 Apr 2012, Minchan Kim wrote:

> > Maybe a per-thread_info variant of gfp_allowed_mask?  So Andrew's 
> > set_current_gfp() becomes set_current_gfp_allowed() that does
> > 
> > 	void set_current_gfp_allowed(gfp_t gfp_mask)
> > 	{
> > 		current->gfp_allowed = gfp_mask & gfp_allowed_mask;
> > 	}
> > 
> > and then the page allocator does
> > 
> > 	gfp_mask &= current->gfp_allowed;
> > 
> > rather than how it currently does
> > 
> > 	gfp_mask &= gfp_allowed_mask;
> > 
> > and then the caller of set_current_gfp_allowed() cleans up with 
> > set_current_gfp_allowed(__GFP_BITS_MASK).
> 

[trimmed the newsgroups from the reply, not sure what the point is?]

> Caller should restore old gfp_mask instead of __GFP_BITS_MASK in case of
> nesting.And how do we care of atomic context?
> 

Eek, I'm hoping these aren't going to be nested but sure that seems 
appropraite if they are.  (I'm also hoping these will only be either 
__GFP_HIGH or __GFP_BITS_MASK and no other combinations.)

Forcing atomic context would just be set_current_gfp_allowed(__GFP_HIGH).

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-04-27 10:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  8:55 Minchan Kim
2012-04-24  5:16 ` KAMEZAWA Hiroyuki
2012-04-24  5:35   ` Minchan Kim
2012-04-24  6:13     ` Nick Piggin
2012-04-24  7:19       ` Minchan Kim
2012-04-24  7:48         ` Nick Piggin
2012-04-24  8:01           ` Minchan Kim
2012-04-24  8:05             ` Nick Piggin
2012-04-24 21:30           ` Andrew Morton
2012-04-24 23:49             ` KAMEZAWA Hiroyuki
2012-04-24 23:55               ` KOSAKI Motohiro
2012-04-25  0:05                 ` KAMEZAWA Hiroyuki
2012-04-25  0:25                   ` Andrew Morton
2012-04-26  0:05                     ` KAMEZAWA Hiroyuki
2012-04-26  0:20                       ` David Rientjes
2012-04-27  2:24                         ` Minchan Kim
2012-04-27  3:08                           ` Andrew Morton
2012-04-27 10:43                           ` David Rientjes [this message]
2012-04-30  1:25                             ` Minchan Kim
2012-05-01  7:20             ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1204270340450.11866@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=minchan@kernel.org \
    --cc=mingo@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=riel@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox