From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx184.postini.com [74.125.245.184]) by kanga.kvack.org (Postfix) with SMTP id 2AC176B004A for ; Tue, 24 Apr 2012 16:26:00 -0400 (EDT) Received: by iajr24 with SMTP id r24so2068153iaj.14 for ; Tue, 24 Apr 2012 13:25:59 -0700 (PDT) Date: Tue, 24 Apr 2012 13:25:57 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH 17/23] kmem controller charge/uncharge infrastructure In-Reply-To: <4F96BB62.1030900@parallels.com> Message-ID: References: <1334959051-18203-1-git-send-email-glommer@parallels.com> <1335138820-26590-6-git-send-email-glommer@parallels.com> <20120424142232.GC8626@somewhere> <4F96BB62.1030900@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: Frederic Weisbecker , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@openvz.org, KAMEZAWA Hiroyuki , Michal Hocko , Johannes Weiner , Greg Thelen , Suleiman Souhlal , Christoph Lameter , Pekka Enberg On Tue, 24 Apr 2012, Glauber Costa wrote: > I think memcg is not necessarily wrong. That is because threads in a process > share an address space, and you will eventually need to map a page to deliver > it to userspace. The mm struct points you to the owner of that. > > But that is not necessarily true for things that live in the kernel address > space. > > Do you view this differently ? > Yes, for user memory, I see charging to p->mm->owner as allowing that process to eventually move and be charged to a different memcg and there's no way to do proper accounting if the charge is split amongst different memcgs because of thread membership to a set of memcgs. This is consistent with charges for shared memory being moved when a thread mapping it moves to a new memcg, as well. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org