From: David Rientjes <rientjes@google.com>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH linux-next] mm/hugetlb: fix warning in alloc_huge_page/dequeue_huge_page_vma
Date: Tue, 17 Apr 2012 13:25:45 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1204171324500.10932@chino.kir.corp.google.com> (raw)
In-Reply-To: <20120417122819.7438.26117.stgit@zurg>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 848 bytes --]
On Tue, 17 Apr 2012, Konstantin Khlebnikov wrote:
> This patch fixes gcc warning (and bug?) introduced in linux-next commit cc9a6c877
> ("cpuset: mm: reduce large amounts of memory barrier related damage v3")
>
> Local variable "page" can be uninitialized if nodemask from vma policy does not
> intersects with nodemask from cpuset. Even if it wouldn't happens it's better to
> initialize this variable explicitly than to introduce kernel oops on weird corner case.
>
> mm/hugetlb.c: In function a??alloc_huge_pagea??:
> mm/hugetlb.c:1135:5: warning: a??pagea?? may be used uninitialized in this function
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
> Cc: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com>
This isn't just in -next, it's also in Linus' tree and seems like 3.4-rc4
material to me.
next prev parent reply other threads:[~2012-04-17 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 12:28 Konstantin Khlebnikov
2012-04-17 14:05 ` Mel Gorman
2012-04-17 20:25 ` David Rientjes [this message]
2012-04-17 20:57 ` Andrew Morton
2012-04-18 5:58 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1204171324500.10932@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox