From: David Rientjes <rientjes@google.com>
To: Glauber Costa <glommer@parallels.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [patch] mm, mempolicy: dummy slab_node return value for bugless kernels
Date: Wed, 7 Mar 2012 13:04:07 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1203071303080.7640@chino.kir.corp.google.com> (raw)
In-Reply-To: <4F5742AF.7090409@parallels.com>
On Wed, 7 Mar 2012, Glauber Costa wrote:
> > I don't suspect we'll be very popular if we try to remove it, I can see
> > how it would be useful when BUG() is used when the problem isn't really
> > fatal (to stop something like disk corruption), like the above case isn't.
> I guess everyone that is able to track the problem back to an instance of
> BUG(), be skilled enough to be sure it is not fatal, and then recompile the
> kernel with this option (that I bet many of us didn't even know that existed),
> can very well just change it to a WARN_*, (and maybe patch it upstream).
>
That's the point of the next patch which changes this to a WARN_ON_ONCE(1)
because all of the BUG()'s that it changes in mm/mempolicy.c aren't fatal.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-03-07 21:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-04 21:43 David Rientjes
2012-03-06 20:15 ` Rafael Aquini
2012-03-07 0:08 ` Andrew Morton
2012-03-07 0:55 ` Rafael Aquini
2012-03-07 4:25 ` David Rientjes
2012-03-07 4:29 ` [patch] mm, mempolicy: make mempolicies robust against errors David Rientjes
2012-03-07 5:30 ` KOSAKI Motohiro
2012-03-07 5:58 ` David Rientjes
2012-03-07 6:34 ` KOSAKI Motohiro
2012-03-07 6:56 ` David Rientjes
2012-03-07 16:24 ` KOSAKI Motohiro
2012-03-07 21:06 ` David Rientjes
2012-03-08 23:51 ` Andrew Morton
2012-04-26 14:58 ` Christoph Lameter
2012-03-07 11:12 ` [patch] mm, mempolicy: dummy slab_node return value for bugless kernels Glauber Costa
2012-03-07 21:04 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1203071303080.7640@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=glommer@parallels.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox