linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [patch] mm, oom: allow exiting tasks to have access to memory reserves
Date: Tue, 6 Mar 2012 23:21:52 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1203062316430.4158@chino.kir.corp.google.com> (raw)
In-Reply-To: <4F570286.8020704@gmail.com>

On Wed, 7 Mar 2012, KOSAKI Motohiro wrote:

> As far as I remembered, this idea was sometimes NAKed and you don't bring new
> idea here.

Nope, all patches I've ever proposed for the oom killer have been merged 
in some form or another.

> When exiting a process which have plenty threads, this patch allow to eat all
> of reserve memory
> and bring us new serious failure.
> 

It closes the risk of livelock if an oom killed thread, thread A, cannot 
exit because it's blocked on another thread, thread B, which cannot exit 
because it requires memory in the exit path and doesn't have access to 
memory reserves.  So this patch makes it more likely that an oom killed 
thread will be able to exit without livelocking.

You do remind me that we can remove this logic from select_bad_process(), 
however, as a cleanup which results in more lines being removed than 
added.  I'll reply with a v2.

Thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-03-07  7:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07  2:25 David Rientjes
2012-03-07  6:39 ` KOSAKI Motohiro
2012-03-07  7:21   ` David Rientjes [this message]
2012-03-07  7:22     ` [patch v2] " David Rientjes
2012-03-08 20:08     ` [patch] " Andrew Morton
2012-03-08 21:59       ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1203062316430.4158@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox