linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Rafael Aquini <aquini@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Randy Dunlap <rdunlap@xenotime.net>,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
	Rik van Riel <riel@redhat.com>, Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics
Date: Tue, 6 Mar 2012 19:41:55 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.00.1203061941210.24600@chino.kir.corp.google.com> (raw)
In-Reply-To: <20120305181041.GA9829@x61.redhat.com>

On Mon, 5 Mar 2012, Rafael Aquini wrote:

> diff --git a/mm/slab.c b/mm/slab.c
> index f0bd785..4aeb5e7 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1731,6 +1731,52 @@ static int __init cpucache_init(void)
>  }
>  __initcall(cpucache_init);
>  
> +static noinline void
> +slab_out_of_memory(struct kmem_cache *cachep, gfp_t gfpflags, int nodeid)
> +{
> +	struct kmem_list3 *l3;
> +	struct slab *slabp;
> +	unsigned long flags;
> +	int node;
> +
> +	printk(KERN_WARNING
> +		"SLAB: Unable to allocate memory on node %d (gfp=0x%x)\n",
> +		nodeid, gfpflags);
> +	printk(KERN_WARNING "   cache: %s, object size: %d, order: %d\n",
> +		cachep->name, cachep->buffer_size, cachep->gfporder);
> +
> +	for_each_online_node(node) {
> +		unsigned long active_objs = 0, num_objs = 0, free_objects = 0;
> +		unsigned long active_slabs = 0, num_slabs = 0;
> +
> +		l3 = cachep->nodelists[node];
> +		if (!l3)
> +			continue;
> +
> +		spin_lock_irqsave(&l3->list_lock, flags);

Could be spin_lock_irq(&l3->list_lock);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2012-03-07  3:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 18:10 Rafael Aquini
2012-03-05 20:02 ` Rik van Riel
2012-03-07  3:41 ` David Rientjes [this message]
2012-03-07 14:18   ` Rafael Aquini
2012-03-07  5:06 ` Cong Wang
2012-03-07  5:42   ` David Rientjes
2012-03-07 14:46     ` Rafael Aquini
2012-03-09 19:41       ` Pekka Enberg
2012-03-09 20:27         ` [PATCH v3] " Rafael Aquini
2012-03-09 20:33           ` Pekka Enberg
2012-03-09 23:46           ` David Rientjes
2012-03-10  8:48             ` Pekka Enberg
2012-03-10  0:23           ` Eric Dumazet
2012-03-10  3:16             ` Rafael Aquini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1203061941210.24600@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=aquini@redhat.com \
    --cc=cl@linux-foundation.org \
    --cc=josef@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox