From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx203.postini.com [74.125.245.203]) by kanga.kvack.org (Postfix) with SMTP id 2BF4A6B00E8 for ; Fri, 24 Feb 2012 05:03:52 -0500 (EST) Received: by dadv6 with SMTP id v6so2786211dad.14 for ; Fri, 24 Feb 2012 02:03:51 -0800 (PST) Date: Fri, 24 Feb 2012 02:03:49 -0800 (PST) From: David Rientjes Subject: Re: [PATCH] oom: add sysctl to enable slab memory dump In-Reply-To: Message-ID: References: <20120222115320.GA3107@x61.redhat.com> <20120223152226.GA2014@x61.redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Rafael Aquini , linux-mm@kvack.org, Randy Dunlap , Christoph Lameter , Matt Mackall , Rik van Riel , Josef Bacik , linux-kernel@vger.kernel.org On Fri, 24 Feb 2012, Pekka Enberg wrote: > Right. We should drop the sysctl and make it into a kernel command line > debugging option instead. > I like how slub handles this when it can't allocate more slab with slab_out_of_memory() and has the added benefit of still warning even with __GFP_NORETRY that the oom killer is never called for. If there's really a slab leak happening, there's a good chance that this diagnostic information is going to be emitted by the offending cache at some point in time if you're using slub. This could easily be extended to slab.c, so it's even more reason not to include this type of information in the oom killer. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org