From: David Rientjes <rientjes@google.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Rafael Aquini <aquini@redhat.com>,
linux-mm@kvack.org, Randy Dunlap <rdunlap@xenotime.net>,
Christoph Lameter <cl@linux-foundation.org>,
Matt Mackall <mpm@selenic.com>, Rik van Riel <riel@redhat.com>,
Josef Bacik <josef@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oom: add sysctl to enable slab memory dump
Date: Fri, 24 Feb 2012 02:03:49 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1202240200380.24971@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1202240856370.1917@tux.localdomain>
On Fri, 24 Feb 2012, Pekka Enberg wrote:
> Right. We should drop the sysctl and make it into a kernel command line
> debugging option instead.
>
I like how slub handles this when it can't allocate more slab with
slab_out_of_memory() and has the added benefit of still warning even with
__GFP_NORETRY that the oom killer is never called for. If there's really
a slab leak happening, there's a good chance that this diagnostic
information is going to be emitted by the offending cache at some point in
time if you're using slub. This could easily be extended to slab.c, so
it's even more reason not to include this type of information in the oom
killer.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-24 10:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 11:53 Rafael Aquini
2012-02-22 13:17 ` Pekka Enberg
2012-02-22 16:04 ` Rafael Aquini
2012-02-22 13:55 ` Christoph Lameter
2012-02-22 16:14 ` Rafael Aquini
2012-02-22 16:29 ` Christoph Lameter
2012-02-23 0:44 ` David Rientjes
2012-02-23 15:02 ` Josef Bacik
2012-02-23 23:09 ` David Rientjes
2012-02-24 15:10 ` Josef Bacik
2012-02-24 21:45 ` David Rientjes
2012-02-24 21:52 ` Pekka Enberg
2012-02-24 23:51 ` David Rientjes
2012-02-23 15:22 ` Rafael Aquini
2012-02-23 16:03 ` Pekka Enberg
2012-02-23 23:17 ` David Rientjes
2012-02-24 6:57 ` Pekka Enberg
2012-02-24 10:03 ` David Rientjes [this message]
2012-02-24 10:05 ` Pekka Enberg
2012-02-24 10:38 ` Rafael Aquini
2012-02-29 3:39 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1202240200380.24971@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aquini@redhat.com \
--cc=cl@linux-foundation.org \
--cc=josef@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox