From: Christoph Lameter <cl@linux.com>
To: Yang Bai <hamo.by@gmail.com>
Cc: penberg@kernel.org, mpm@selenic.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: warning if total alloc size overflow
Date: Tue, 14 Feb 2012 09:03:36 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1202140902400.20013@router.home> (raw)
In-Reply-To: <1329204499-2671-1-git-send-email-hamo.by@gmail.com>
On Tue, 14 Feb 2012, Yang Bai wrote:
> Before, if the total alloc size is overflow,
> we just return NULL like alloc fail. But they
> are two different type problems. The former looks
> more like a programming problem. So add a warning
> here.
Acked-by: Christoph Lameter <cl@linux.com>
Would be better to remove kcalloc and provide a generalized array size
calculation function that does the WARN(). That would also work for all
other variants zeroed or NUMA node spec etc etc.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-02-14 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 7:28 Yang Bai
2012-02-14 7:31 ` Pekka Enberg
2012-02-14 7:51 ` Yang Bai
2012-02-14 8:10 ` Pekka Enberg
2012-02-14 15:04 ` Christoph Lameter
2012-02-14 8:53 ` Andrew Morton
2012-02-14 9:43 ` Yang Bai
2012-02-14 15:07 ` Christoph Lameter
2012-02-14 15:03 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1202140902400.20013@router.home \
--to=cl@linux.com \
--cc=hamo.by@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox