From: Christoph Lameter <cl@linux.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] mm: Remove NUMA_INTERLEAVE_HIT
Date: Fri, 13 Jan 2012 13:28:02 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.00.1201131326370.28535@router.home> (raw)
In-Reply-To: <20120113183926.GL11715@one.firstfloor.org>
On Fri, 13 Jan 2012, Andi Kleen wrote:
> On Fri, Jan 13, 2012 at 09:28:20AM -0600, Christoph Lameter wrote:
> > On Thu, 12 Jan 2012, Andi Kleen wrote:
> >
> > > The problem is that then there will be nothing left that actually
> > > tests interleaving. The numactl has caught kernel regressions in the past.
> >
> > How about adding a CONFIG_NUMA_DEBUG option and have it only available
> > then? I think there is no general use case.
>
> For a few lines of code? And making it harder to test?
For now yes. We can then add more debugging stuff. Right now there is no
framework for that.
> > > I don't think disabling useful regression tests is a good idea.
> > > In contrary the kernel needs far more of them, not less.
> >
> > True. Some more debugging code for the NUMA features would be appreciated
> > but that does not need to be enabled by default. Lately I have become a
> > bit concerned about the number of statistics we are adding. The
> > per_cpu_pageset structure should not get too large.
>
> I don't think the single counter is a problem.
I never said that .... There are multiple counters that may not be
too useful in that structure. Not just the one thats useless.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-01-13 19:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 15:07 Peter Zijlstra
2012-01-12 17:37 ` Christoph Lameter
2012-01-12 18:26 ` Andi Kleen
2012-01-12 19:02 ` KOSAKI Motohiro
2012-01-12 19:10 ` Andi Kleen
2012-01-12 20:13 ` Peter Zijlstra
2012-01-12 21:07 ` Andi Kleen
2012-01-12 21:40 ` Andrew Morton
2012-01-12 22:29 ` Andi Kleen
2012-01-13 15:28 ` Christoph Lameter
2012-01-13 18:39 ` Andi Kleen
2012-01-13 19:28 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1201131326370.28535@router.home \
--to=cl@linux.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox