From: David Rientjes <rientjes@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Tom Gundersen <teg@jklm.no>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mark some messages as INFO
Date: Wed, 7 Dec 2011 13:41:38 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1112071340420.27360@chino.kir.corp.google.com> (raw)
In-Reply-To: <20111207191637.GB12679@cmpxchg.org>
On Wed, 7 Dec 2011, Johannes Weiner wrote:
> > @@ -4913,31 +4913,31 @@ void __init free_area_init_nodes(unsigned long *max_zone_pfn)
> > find_zone_movable_pfns_for_nodes(zone_movable_pfn);
> >
> > /* Print out the zone ranges */
> > - printk("Zone PFN ranges:\n");
> > + printk(KERN_INFO "Zone PFN ranges:\n");
> > for (i = 0; i < MAX_NR_ZONES; i++) {
> > if (i == ZONE_MOVABLE)
> > continue;
> > - printk(" %-8s ", zone_names[i]);
> > + printk(KERN_INFO " %-8s ", zone_names[i]);
> > if (arch_zone_lowest_possible_pfn[i] ==
> > arch_zone_highest_possible_pfn[i])
> > - printk("empty\n");
> > + printk(KERN_INFO "empty\n");
> > else
> > - printk("%0#10lx -> %0#10lx\n",
> > + printk(KERN_INFO "%0#10lx -> %0#10lx\n",
> > arch_zone_lowest_possible_pfn[i],
> > arch_zone_highest_possible_pfn[i]);
> > }
>
> Shouldn't continuation lines be KERN_CONT instead?
>
Indeed, and I think it would benefit from using pr_info() and pr_cont() as
well to avoid going over 80 characters per line.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-12-07 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 17:02 Tom Gundersen
2011-12-07 17:12 ` KOSAKI Motohiro
2011-12-07 19:16 ` Johannes Weiner
2011-12-07 21:41 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1112071340420.27360@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox