From: David Rientjes <rientjes@google.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Jens Axboe <axboe@kernel.dk>, Christoph Lameter <cl@linux.com>,
"lee.schermerhorn@hp.com" <lee.schermerhorn@hp.com>
Subject: Re: [patch v2]numa: add a sysctl to control interleave allocation granularity from each node
Date: Tue, 6 Dec 2011 17:42:10 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1112061739140.27247@chino.kir.corp.google.com> (raw)
In-Reply-To: <20111207013754.GA23364@sli10-conroe.sh.intel.com>
On Wed, 7 Dec 2011, Shaohua Li wrote:
> based on the allocation size, right? I did consider it. It would be easy to
> implement this. Note even without my patch we have the issue if allocation
> from one node is big order and small order from other node. And nobody
> complains the imbalance. This makes me think maybe people didn't care
> about the imbalance too much.
>
Right, I certainly see what you're trying to do and I support it, however,
if we're going to add a userspace tunable then I think it would be better
implemented as a size. You can still get the functionality that you have
with your patch (just with a size of 0, the default, making every
allocation on the next node) but can also interleave on PAGE_SIZE,
HPAGE_SIZE, etc, increments. I think it would help for users who are
concerned about node symmetry for contention on the memory bus and it
would be a shame if someone needed to add a second tunable for that affect
if your tunable already has applications using it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-07 1:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 3:30 Shaohua Li
2011-12-06 20:52 ` David Rientjes
2011-12-07 1:37 ` Shaohua Li
2011-12-07 1:42 ` David Rientjes [this message]
2011-12-07 5:03 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1112061739140.27247@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cl@linux.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox