From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 5AA146B00B0 for ; Wed, 23 Nov 2011 01:32:53 -0500 (EST) Received: by iaek3 with SMTP id k3so1541459iae.14 for ; Tue, 22 Nov 2011 22:32:48 -0800 (PST) Date: Tue, 22 Nov 2011 22:32:45 -0800 (PST) From: David Rientjes Subject: Re: [PATCH] vmscan: add task name to warn_scan_unevictable() messages In-Reply-To: <20111123062405.GA25067@barrios-laptop.redhat.com> Message-ID: References: <1322027721-23677-1-git-send-email-kosaki.motohiro@jp.fujitsu.com> <20111123062405.GA25067@barrios-laptop.redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: KOSAKI Motohiro , Johannes Weiner , Andrew Morton , Mel Gorman , KAMEZAWA Hiroyuki , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed, 23 Nov 2011, Minchan Kim wrote: > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index a1893c0..29d163e 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -3448,9 +3448,10 @@ void scan_mapping_unevictable_pages(struct address_space *mapping) > > static void warn_scan_unevictable_pages(void) > > { > > printk_once(KERN_WARNING > > - "The scan_unevictable_pages sysctl/node-interface has been " > > + "%s: The scan_unevictable_pages sysctl/node-interface has been " > > "disabled for lack of a legitimate use case. If you have " > > - "one, please send an email to linux-mm@kvack.org.\n"); > > + "one, please send an email to linux-mm@kvack.org.\n", > > + current->comm); > > } > > Just nitpick: > How about using WARN_ONCE instead of custom warning? > It can show more exact call path as well as comm. > I guess it's more noticible to users. > Anyway, either is okay to me. > When I used WARN_ONCE() to notify users that /proc/pid/oom_adj was deprecated, people complained that it triggered userspace log parsers thinking that there's a serious problem and it adds a taint flag so it got reverted. I'd recommend keeping it printk_once(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org