Re: [patch] slub: fix a code merge error

[David Rientjes <rientjes@google.com>]

On Tue, 15 Nov 2011, Pekka Enberg wrote:

> > SLUB stat attribute was designed for stat accounting only. I checked
> > the total 24 attributes that used now. All of them used in stat() only
> > except the DEACTIVATE_TO_HEAD/TAIL.
> > 
> > And in fact, in the most of using scenarios the DEACTIVATE_TO_TAIL
> > make reader confuse, TO_TAIL is correct but not for DEACTIVATE.
> > 
> > Further more, CL also regretted this after he acked the original
> > patches for this attribute mis-usages. He said "don't think we want
> > this patch any more."
> > http://permalink.gmane.org/gmane.linux.kernel.mm/67653 and want to use
> > a comment instead of this confusing usage.
> > https://lkml.org/lkml/2011/8/29/187
> > 
> > So, as to this regression, from my viewpoint, reverting the
> > DEACTIVATE_TO_TAIL incorrect usage(commit 136333d104) is a better way.
> > :)
> 
> The enum is fine. I don't see any reason to revert the whole commit if
> Shaohua's patch fixes the problem.
> 

It's a slight optimization since "tail" can be set in deactivate_slab() 
and be passed to add_partial() without doing something like !!tail or 
converting it to a boolean as well as using it when calling stat().

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>