From: David Rientjes <rientjes@google.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Christoph Lameter <cl@gentwo.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 1/2] slab: rename slab_break_gfp_order to slab_max_order
Date: Thu, 3 Nov 2011 14:40:34 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1111031440130.31612@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1110182207500.5907@chino.kir.corp.google.com>
On Tue, 18 Oct 2011, David Rientjes wrote:
> slab_break_gfp_order is more appropriately named slab_max_order since it
> enforces the maximum order size of slabs as long as a single object will
> still fit.
>
> Also rename BREAK_GFP_ORDER_{LO,HI} accordingly.
>
Ping on these two patches? I don't see them in slab/next.
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> mm/slab.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -481,9 +481,9 @@ EXPORT_SYMBOL(slab_buffer_size);
> /*
> * Do not go above this order unless 0 objects fit into the slab.
> */
> -#define BREAK_GFP_ORDER_HI 1
> -#define BREAK_GFP_ORDER_LO 0
> -static int slab_break_gfp_order = BREAK_GFP_ORDER_LO;
> +#define SLAB_MAX_ORDER_HI 1
> +#define SLAB_MAX_ORDER_LO 0
> +static int slab_max_order = SLAB_MAX_ORDER_LO;
>
> /*
> * Functions for storing/retrieving the cachep and or slab from the page
> @@ -1502,7 +1502,7 @@ void __init kmem_cache_init(void)
> * page orders on machines with more than 32MB of memory.
> */
> if (totalram_pages > (32 << 20) >> PAGE_SHIFT)
> - slab_break_gfp_order = BREAK_GFP_ORDER_HI;
> + slab_max_order = SLAB_MAX_ORDER_HI;
>
> /* Bootstrap is tricky, because several objects are allocated
> * from caches that do not exist yet:
> @@ -2112,7 +2112,7 @@ static size_t calculate_slab_order(struct kmem_cache *cachep,
> * Large number of objects is good, but very large slabs are
> * currently bad for the gfp()s.
> */
> - if (gfporder >= slab_break_gfp_order)
> + if (gfporder >= slab_max_order)
> break;
>
> /*
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-03 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 5:09 David Rientjes
2011-10-19 5:09 ` [patch 2/2] slab: introduce slab_max_order kernel parameter David Rientjes
2011-11-03 21:40 ` David Rientjes [this message]
2011-11-09 19:19 ` [patch 1/2] slab: rename slab_break_gfp_order to slab_max_order Pekka Enberg
2011-11-09 19:30 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1111031440130.31612@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cl@gentwo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox