From: David Rientjes <rientjes@google.com>
To: Colin Cross <ccross@android.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: avoid livelock on !__GFP_FS allocations
Date: Tue, 25 Oct 2011 15:12:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1110251510240.26017@chino.kir.corp.google.com> (raw)
In-Reply-To: <CAMbhsRQs+P9djqW_62ajfZTHE3yxsOs0agek81aZrBzZ2-5-Fg@mail.gmail.com>
On Tue, 25 Oct 2011, Colin Cross wrote:
> GFP_KERNEL is __GFP_WAIT | __GFP_IO | __GFP_FS. Once driver suspend
> has started, gfp_allowed_mask is ~(__GFP_IO | GFP_FS), so any call to
> __alloc_pages_nodemask(GFP_KERNEL, ...) gets masked to effectively
> __alloc_pages_nodemask(__GFP_WAIT, ...).
>
Just passing __GFP_WAIT is the problem that you're trying to address,
though. Why not include __GFP_NORETRY since you know the liklihood of
allocation being successful on the second iteration is very slim since
you're not in a context where you can force reclaim or oom killing?
> The loop is in __alloc_pages_slowpath, from the rebalance label to
> should_alloc_retry.
The loop is by design and is activated because you're just passing
__GFP_WAIT in this context for no sensible reason.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-25 22:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 6:39 Colin Cross
2011-10-25 7:40 ` Pekka Enberg
2011-10-25 7:51 ` Colin Cross
2011-10-25 8:08 ` Pekka Enberg
2011-10-25 22:12 ` David Rientjes [this message]
2011-10-25 9:09 ` Mel Gorman
2011-10-25 9:26 ` Colin Cross
2011-10-25 11:23 ` Mel Gorman
2011-10-25 17:08 ` Colin Cross
2011-11-01 12:28 ` Mel Gorman
2011-10-25 19:39 ` Pekka Enberg
2011-11-01 12:29 ` Mel Gorman
2011-10-25 19:29 ` Colin Cross
2011-10-25 22:18 ` David Rientjes
2011-10-26 1:46 ` Colin Cross
2011-10-26 5:47 ` David Rientjes
2011-10-26 6:12 ` David Rientjes
2011-10-26 6:16 ` Colin Cross
2011-10-26 6:24 ` David Rientjes
2011-10-26 6:26 ` Colin Cross
2011-10-26 6:33 ` David Rientjes
2011-10-26 6:36 ` Colin Cross
2011-10-26 6:51 ` David Rientjes
2011-10-26 6:57 ` Colin Cross
2011-10-26 7:10 ` David Rientjes
2011-10-26 7:22 ` Colin Cross
2011-11-01 12:36 ` Mel Gorman
2011-10-25 22:10 ` David Rientjes
2011-11-14 14:04 Mel Gorman
2011-11-14 18:38 ` Andrea Arcangeli
2011-11-15 10:30 ` Mel Gorman
2011-11-14 23:03 ` Andrew Morton
2011-11-15 10:42 ` Mel Gorman
2011-11-15 15:43 ` Mel Gorman
2011-11-15 16:13 ` Minchan Kim
2011-11-15 17:36 ` Mel Gorman
2011-11-16 0:22 ` Minchan Kim
2011-11-16 0:28 ` Colin Cross
2011-11-16 0:45 ` Minchan Kim
2011-11-16 7:10 ` Pekka Enberg
2011-11-16 21:44 ` David Rientjes
2011-11-16 21:58 ` Rafael J. Wysocki
2011-11-16 22:07 ` Minchan Kim
2011-11-16 22:48 ` David Rientjes
2011-11-15 21:40 ` David Rientjes
2011-11-16 9:52 ` Mel Gorman
2011-11-16 21:39 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1110251510240.26017@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox