From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-mm@kvack.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [patch v2] oom: thaw threads if oom killed thread is frozen before deferring
Date: Tue, 11 Oct 2011 16:36:28 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1110111633160.5236@chino.kir.corp.google.com> (raw)
In-Reply-To: <20111011063336.GA23284@tiehlicka.suse.cz>
On Tue, 11 Oct 2011, Michal Hocko wrote:
> The patch looks good but we still need other 2 patches
> (http://comments.gmane.org/gmane.linux.kernel.mm/68578), right?
>
For the lguest patch, Rusty is the maintainer and has already acked the
patch, so I think it should be merged through him. I don't see a need for
the second patch since we'll now detect frozen oom killed tasks on retry
and don't need to kill them directly when oom killed (it just adds
additional, unnecessary code).
> Anyway, I thought that we agreed on the other approach suggested by
> Tejun (make frozen tasks oom killable without thawing). Even in that
> case we want the first patch
> (http://permalink.gmane.org/gmane.linux.kernel.mm/68576).
If that's possible, then we can just add Tejun to add a follow-up patch to
remove the thaw directly in the oom killer. I'm thinking that won't be
possible for 3.2, though, so I don't know why we'd remove
oom-thaw-threads-if-oom-killed-thread-is-frozen-before-deferring.patch
from -mm?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-11 23:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-08 2:56 [patch resend] " David Rientjes
2011-10-08 2:59 ` [patch v2] " David Rientjes
2011-10-08 7:23 ` KOSAKI Motohiro
2011-10-11 6:33 ` Michal Hocko
2011-10-11 14:50 ` KOSAKI Motohiro
2011-10-11 15:14 ` Michal Hocko
2011-10-11 15:57 ` KOSAKI Motohiro
2011-10-11 19:07 ` Michal Hocko
2011-10-11 23:36 ` David Rientjes [this message]
2011-10-11 23:39 ` Tejun Heo
2011-10-11 23:46 ` David Rientjes
2011-10-12 6:50 ` Michal Hocko
2011-10-12 6:58 ` Michal Hocko
2011-10-11 19:16 ` [patch resend] " Oleg Nesterov
2011-10-11 23:30 ` David Rientjes
2011-10-11 23:41 ` Andrew Morton
2011-10-12 14:40 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1110111633160.5236@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox