From: David Rientjes <rientjes@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
James.Bottomley@hansenpartnership.com, hpa@zytor.com
Subject: Re: [RFCv3][PATCH 4/4] show page size in /proc/$pid/numa_maps
Date: Wed, 5 Oct 2011 12:24:24 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1110051219370.23587@chino.kir.corp.google.com> (raw)
In-Reply-To: <1317832083.2473.58.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Wed, 5 Oct 2011, Eric Dumazet wrote:
> > How does it break old scripts?
> >
>
> Old scripts just parse numa_maps, and on typical machines where
> hugepages are not used, they dont have to care about page size.
> They assume pages are 4KB.
>
> Adding a new word (pagesize=...) might break them, but personally I dont
> care.
>
If your script is only parsing numa_maps, then Dave's effort is actually
allowing them to be fixed rather than breaking them. We could silently
continue to export the page counts without specifying the size (hugetlb
pages are counted in their true hugepage size, THP pages are counted in
PAGE_SIZE units), but then a script would always be broken unless they use
smaps as well. Dave's addition of pagesize allows numa_maps to stand on
its own and actually be useful when hugepages are used.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-05 19:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-01 0:08 [RFCv3][PATCH 1/4] replace string_get_size() arrays Dave Hansen
2011-10-01 0:08 ` [RFCv3][PATCH 2/4] add string_get_size_pow2() Dave Hansen
2011-10-01 0:08 ` [RFCv3][PATCH 3/4] add seq_print_pow2() function Dave Hansen
2011-10-01 0:09 ` [RFCv3][PATCH 4/4] show page size in /proc/$pid/numa_maps Dave Hansen
2011-10-05 6:50 ` David Rientjes
2011-10-05 7:09 ` Eric Dumazet
2011-10-05 7:23 ` David Rientjes
2011-10-05 8:54 ` Eric Dumazet
2011-10-05 19:19 ` David Rientjes
2011-10-05 15:22 ` Dave Hansen
2011-10-05 16:28 ` Eric Dumazet
2011-10-05 19:24 ` David Rientjes [this message]
2011-10-05 15:21 ` Dave Hansen
2011-10-01 19:29 ` [RFCv3][PATCH 1/4] replace string_get_size() arrays Joe Perches
2011-10-01 19:33 ` Joe Perches
2011-10-04 19:35 ` Dave Hansen
2011-10-04 20:42 ` Joe Perches
2011-10-04 20:51 ` Dave Hansen
2011-10-04 21:18 ` Joe Perches
2011-10-05 6:58 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1110051219370.23587@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dave@linux.vnet.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox