From: David Rientjes <rientjes@google.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] show page size in /proc/$pid/numa_maps
Date: Fri, 23 Sep 2011 13:04:12 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1109231256540.11347@chino.kir.corp.google.com> (raw)
In-Reply-To: <1316793268.16137.481.camel@nimitz>
On Fri, 23 Sep 2011, Dave Hansen wrote:
> > Why not just add a pagesize={4K,2M,1G,...} field for every output?
>
> I think it's a bit misleading. With THP at least we have 2M pages in
> the MMU, but we're reporting in 4k units.
>
> I certainly considered doing just what you're suggesting, though. It's
> definitely not a bad idea. Certainly much more clear.
>
Een though the code is in task_mmu.c, I think that /proc/pid/numa_maps
should be more representative of the state of vmas where any
pagesize={4K,2M,1G,...} would be true rather than whether or not the mmu
sees tham as large or small pages. I actually don't see much difference
between anon=50 pagemult=512 and anon=50 pagesize=2M, but I'd definitely
recommend printing the field for every vma.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-09-23 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 22:13 Dave Hansen
2011-09-22 20:43 ` David Rientjes
2011-09-23 15:54 ` Dave Hansen
2011-09-23 20:04 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1109231256540.11347@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox