From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta12.messagelabs.com (mail6.bemta12.messagelabs.com [216.82.250.247]) by kanga.kvack.org (Postfix) with ESMTP id 3E1E76B016A for ; Thu, 25 Aug 2011 16:57:25 -0400 (EDT) Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id p7PKvNYs005726 for ; Thu, 25 Aug 2011 13:57:23 -0700 Received: from pzk2 (pzk2.prod.google.com [10.243.19.130]) by wpaz21.hot.corp.google.com with ESMTP id p7PKvJJo022561 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 25 Aug 2011 13:57:21 -0700 Received: by pzk2 with SMTP id 2so4058464pzk.6 for ; Thu, 25 Aug 2011 13:57:18 -0700 (PDT) Date: Thu, 25 Aug 2011 13:57:16 -0700 (PDT) From: David Rientjes Subject: Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c In-Reply-To: <4E562248.2090102@redhat.com> Message-ID: References: <20110804145834.3b1d92a9eeb8357deb84bf83@canb.auug.org.au> <20110804152211.ea10e3e7.rdunlap@xenotime.net> <20110823143912.0691d442.akpm@linux-foundation.org> <4E547155.8090709@redhat.com> <20110824191430.8a908e70.rdunlap@xenotime.net> <4E55C221.8080100@redhat.com> <20110824205044.7ff45b6c.rdunlap@xenotime.net> <4E562248.2090102@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Cong Wang Cc: Randy Dunlap , Andrew Morton , Stephen Rothwell , gregkh@suse.de, linux-next@vger.kernel.org, LKML , linux-mm@kvack.org On Thu, 25 Aug 2011, Cong Wang wrote: > > No, it doesn't work, CONFIG_HUGETLBFS can be enabled with CONFIG_NUMA=y > > and CONFIG_SYSFS=n and that uses data structures from drivers/base/node.c > > which doesn't get compiled with this patch. > > So, you mean with CONFIG_NUMA=y && CONFIG_SYSFS=n && CONFIG_HUGETLBFS=y > we still get compile error? > > Which data structures are used by hugetlbfs? > node_states[], which is revealed at link time if you tried to compile your patch. It's obvious that we don't want to add per-node hugetlbfs attributes to sysfs directories if sysfs is disabled, so you need to modify the hugetlbfs code as well. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org