From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id ED1DB6B0082 for ; Thu, 21 Jul 2011 12:28:08 -0400 (EDT) Date: Thu, 21 Jul 2011 11:28:04 -0500 (CDT) From: Christoph Lameter Subject: Re: [RFC v3 2/5] slab: implement slab object boundaries assertion In-Reply-To: <1311252815-6733-1-git-send-email-segoon@openwall.com> Message-ID: References: <1311252815-6733-1-git-send-email-segoon@openwall.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Vasiliy Kulikov Cc: linux-kernel@vger.kernel.org, Pekka Enberg , Matt Mackall , linux-mm@kvack.org, Andrew Morton , Ingo Molnar , Greg Kroah-Hartman , Al Viro , Thomas Gleixner On Thu, 21 Jul 2011, Vasiliy Kulikov wrote: > +bool slab_access_ok(const void *ptr, unsigned long len) > +{ > + struct page *page; > + struct kmem_cache *s = NULL; Useless assignment. > + unsigned long offset; > + > + if (!virt_addr_valid(ptr)) > + return true; > + page = virt_to_head_page(ptr); > + if (!PageSlab(page)) > + return true; > + > + s = page->slab; > + offset = (ptr - page_address(page)) % s->size; > + if (offset <= s->objsize && len <= s->objsize - offset) > + return true; I thought this was going to be offset < s->objectsize ...? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org