From: Christoph Lameter <cl@linux.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>, Pekka Enberg <penberg@kernel.org>,
Konstantin Khlebnikov <khlebnikov@openvz.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matt Mackall <mpm@selenic.com>
Subject: Re: [PATCH] mm-slab: allocate kmem_cache with __GFP_REPEAT
Date: Wed, 20 Jul 2011 11:17:57 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1107201114480.1472@router.home> (raw)
In-Reply-To: <1311177362.2338.57.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Wed, 20 Jul 2011, Eric Dumazet wrote:
> Note that adding ____cacheline_aligned_in_smp on nodelists[] actually
> helps performance, as all following fields are readonly after kmem_cache
> setup.
Well but that is not addresssing the same issue. Could you separate that
out?
The other question that follows from this is then: Does that
alignment compensate for the loss of performance due to the additional
lookup in hot code paths and the additional cacheline reference required?
The per node pointers are lower priority in terms of performance than the
per cpu pointers. I'd rather have the per node pointers requiring an
additional lookup. Less impact on hot code paths.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-07-20 16:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 12:16 Konstantin Khlebnikov
2011-07-20 13:14 ` Pekka Enberg
2011-07-20 13:28 ` Konstantin Khlebnikov
2011-07-20 13:42 ` Pekka Enberg
2011-07-20 13:50 ` Konstantin Khlebnikov
2011-07-20 13:53 ` Pekka Enberg
2011-07-20 15:36 ` Christoph Lameter
2011-07-20 13:59 ` Konstantin Khlebnikov
2011-07-20 13:54 ` Christoph Lameter
2011-07-20 14:20 ` Mel Gorman
2011-07-20 14:32 ` Konstantin Khlebnikov
2011-07-20 14:40 ` Eric Dumazet
2011-07-20 14:47 ` Konstantin Khlebnikov
2011-07-20 13:43 ` Mel Gorman
2011-07-20 13:56 ` Christoph Lameter
2011-07-20 14:08 ` Eric Dumazet
2011-07-20 14:52 ` Christoph Lameter
2011-07-20 15:09 ` Eric Dumazet
2011-07-20 15:34 ` Christoph Lameter
2011-07-20 15:56 ` Eric Dumazet
2011-07-20 16:17 ` Christoph Lameter [this message]
2011-07-20 16:31 ` Eric Dumazet
2011-07-20 17:04 ` Eric Dumazet
2011-07-20 17:13 ` Christoph Lameter
2011-07-20 17:28 ` Pekka Enberg
2011-07-20 17:37 ` Christoph Lameter
2011-07-20 17:41 ` Pekka Enberg
2011-07-20 18:07 ` Matt Mackall
2011-07-21 7:18 ` Konstantin Khlebnikov
2011-07-20 19:09 ` Mel Gorman
2011-07-31 11:41 ` Konstantin Khlebnikov
2011-07-31 11:44 ` Pekka Enberg
2011-07-21 8:43 ` Eric Dumazet
2011-07-21 15:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1107201114480.1472@router.home \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox