From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 3D9F66B00E7 for ; Wed, 20 Jul 2011 09:54:15 -0400 (EDT) Date: Wed, 20 Jul 2011 08:54:10 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH] mm-slab: allocate kmem_cache with __GFP_REPEAT In-Reply-To: Message-ID: References: <20110720121612.28888.38970.stgit@localhost6> <4E26D7EA.3000902@parallels.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Konstantin Khlebnikov , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Matt Mackall , "mgorman@suse.de" On Wed, 20 Jul 2011, Pekka Enberg wrote: > On Wed, 20 Jul 2011, Konstantin Khlebnikov wrote: > > > The changelog isn't that convincing, really. This is kmem_cache_create() > > > so I'm surprised we'd ever get NULL here in practice. Does this fix some > > > problem you're seeing? If this is really an issue, I'd blame the page > > > allocator as GFP_KERNEL should just work. > > > > nf_conntrack creates separate slab-cache for each net-namespace, > > this patch of course not eliminates the chance of failure, but makes it more > > acceptable. > > I'm still surprised you are seeing failures. mm/slab.c hasn't changed > significantly in a long time. Why hasn't anyone reported this before? I'd > still be inclined to shift the blame to the page allocator... Mel, Christoph? There was a lot of recent fiddling with the reclaim logic. Maybe some of those changes caused the problem? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org