From: David Rientjes <rientjes@google.com>
To: Christoph Lameter <cl@linux.com>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org, "David S. Miller" <davem@davemloft.net>,
netfilter@vger.kernel.org, Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH] slob: push the min alignment to long long
Date: Wed, 22 Jun 2011 16:41:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1106221641120.14635@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1106141614480.10017@router.home>
On Tue, 14 Jun 2011, Christoph Lameter wrote:
> Index: linux-2.6/include/linux/slab.h
> ===================================================================
> --- linux-2.6.orig/include/linux/slab.h 2011-06-14 15:46:38.000000000 -0500
> +++ linux-2.6/include/linux/slab.h 2011-06-14 15:46:59.000000000 -0500
> @@ -133,6 +133,16 @@ unsigned int kmem_cache_size(struct kmem
> #define KMALLOC_MAX_SIZE (1UL << KMALLOC_SHIFT_HIGH)
> #define KMALLOC_MAX_ORDER (KMALLOC_SHIFT_HIGH - PAGE_SHIFT)
>
> +#ifdef ARCH_DMA_MINALIGN
> +#define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN
> +#else
> +#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
> +#endif
> +
> +#ifndef ARCH_SLAB_MINALIGN
> +#define ARCH_SLAB_MINALIGN __alignof__(unsigned long long)
> +#endif
> +
> /*
> * Common kmalloc functions provided by all allocators
> */
> Index: linux-2.6/include/linux/slab_def.h
> ===================================================================
> --- linux-2.6.orig/include/linux/slab_def.h 2011-06-14 15:47:04.000000000 -0500
> +++ linux-2.6/include/linux/slab_def.h 2011-06-14 15:50:04.000000000 -0500
> @@ -18,32 +18,6 @@
> #include <trace/events/kmem.h>
>
> /*
> - * Enforce a minimum alignment for the kmalloc caches.
> - * Usually, the kmalloc caches are cache_line_size() aligned, except when
> - * DEBUG and FORCED_DEBUG are enabled, then they are BYTES_PER_WORD aligned.
> - * Some archs want to perform DMA into kmalloc caches and need a guaranteed
> - * alignment larger than the alignment of a 64-bit integer.
> - * ARCH_KMALLOC_MINALIGN allows that.
> - * Note that increasing this value may disable some debug features.
> - */
> -#ifdef ARCH_DMA_MINALIGN
> -#define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN
> -#else
> -#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
> -#endif
> -
> -#ifndef ARCH_SLAB_MINALIGN
> -/*
> - * Enforce a minimum alignment for all caches.
> - * Intended for archs that get misalignment faults even for BYTES_PER_WORD
> - * aligned buffers. Includes ARCH_KMALLOC_MINALIGN.
> - * If possible: Do not enable this flag for CONFIG_DEBUG_SLAB, it disables
> - * some debug features.
> - */
> -#define ARCH_SLAB_MINALIGN 0
> -#endif
> -
> -/*
> * struct kmem_cache
> *
> * manages a cache.
Looks like we lost some valuable information in the comments when this got
moved to slab.h :(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-22 23:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 20:10 Sebastian Andrzej Siewior
2011-06-14 20:40 ` Christoph Lameter
2011-06-14 21:16 ` Christoph Lameter
2011-06-15 20:06 ` Sebastian Andrzej Siewior
2011-06-16 16:48 ` Pekka Enberg
2011-06-22 23:41 ` David Rientjes [this message]
2011-06-23 14:36 ` Christoph Lameter
2011-06-23 20:24 ` David Rientjes
2011-06-14 22:05 ` Matt Mackall
2011-06-15 20:12 ` Sebastian Andrzej Siewior
2011-06-15 20:24 ` Matt Mackall
2011-06-15 20:40 ` Pekka Enberg
2011-06-15 20:55 ` Matt Mackall
2011-06-15 22:11 ` David Miller
2011-06-15 22:53 ` Matt Mackall
2011-06-16 6:59 ` Pekka Enberg
2011-06-16 15:23 ` Matt Mackall
2011-06-16 15:28 ` Pekka Enberg
2011-06-15 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1106221641120.14635@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=netfilter@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox