Re: [PATCH] Make GFP_DMA allocations w/o ZONE_DMA emit a warning instead of failing

[David Rientjes <rientjes@google.com>]

On Fri, 10 Jun 2011, Russell King - ARM Linux wrote:

> So those platforms which don't have a DMA zone, don't have any problems
> with DMA, yet want to use the very same driver which does have a problem
> on ISA hardware have to also put up with a useless notification that
> their kernel might be broken?
> 
> Are you offering to participate on other architectures mailing lists to
> answer all the resulting queries?
> 

It all depends on the wording of the "warning", it should make it clear 
that this is not always an error condition and only affects certain types 
of hardware which the user may or may not have.  If you have any 
suggestions on how to alter "task (pid): attempted to allocate DMA memory 
without DMA support -- enable CONFIG_ZONE_DMA if needed" to make that more 
clear, be my guest.  The alternative is that the ISA hardware cannot 
handle the memory returned fails unexpectedly and randomly without any 
clear indication of what the issue is.  I think what would be worse is 
time lost for someone to realize CONFIG_ZONE_DMA isn't enabled, and that 
could be significant (and probably generate many bug reports on its own) 
since it isn't immediately obvious without doing some debugging.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>