From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id D5F796B0027 for ; Fri, 20 May 2011 10:32:05 -0400 (EDT) Date: Fri, 20 May 2011 09:32:01 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH] kernel buffer overflow kmalloc_slab() fix In-Reply-To: <1305843552.2400.36.camel@localhost> Message-ID: References: <1305834712-27805-2-git-send-email-james_p_freyensee@linux.intel.com> <1305839647.2400.32.camel@localhost> <1305843552.2400.36.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: J Freyensee Cc: linux-mm@kvack.org, gregkh@suse.de, hari.k.kanigeri@intel.com On Thu, 19 May 2011, J Freyensee wrote: > > Not sure what to do instead of returning -1 in kmalloc_slab. > > I think returning -1 is fine; I just think code using the function > should be checking for it and protect itself for errors in kernel space. The function never returns -1 as I explained before. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org