From: David Rientjes <rientjes@google.com>
To: Daniel Kiper <dkiper@net-space.pl>
Cc: ian.campbell@citrix.com,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi.kleen@intel.com>,
haicheng.li@linux.intel.com, fengguang.wu@intel.com,
jeremy@goop.org, konrad.wilk@oracle.com,
dan.magenheimer@oracle.com, v.tolstov@selfip.ru, pasik@iki.fi,
Dave Hansen <dave@linux.vnet.ibm.com>,
wdauchy@gmail.com, xen-devel@lists.xensource.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V3 1/2] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro
Date: Wed, 18 May 2011 20:21:23 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1105182019170.20651@chino.kir.corp.google.com> (raw)
In-Reply-To: <20110517213750.GB30232@router-fw-old.local.net-space.pl>
On Tue, 17 May 2011, Daniel Kiper wrote:
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index d715200..217bcf6 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -956,6 +956,9 @@ static inline unsigned long early_pfn_to_nid(unsigned long pfn)
> #define pfn_to_section_nr(pfn) ((pfn) >> PFN_SECTION_SHIFT)
> #define section_nr_to_pfn(sec) ((sec) << PFN_SECTION_SHIFT)
>
> +#define SECTION_ALIGN_UP(pfn) (((pfn) + PAGES_PER_SECTION - 1) & PAGE_SECTION_MASK)
> +#define SECTION_ALIGN_DOWN(pfn) ((pfn) & PAGE_SECTION_MASK)
> +
> struct page;
> struct page_cgroup;
> struct mem_section {
These seem useful. Could you convert the code in drivers/base/node.c,
mm/page_cgroup.c, mm/page_alloc.c, and mm/sparse.c that already do this to
use the new macros?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-19 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 21:37 Daniel Kiper
2011-05-19 3:21 ` David Rientjes [this message]
2011-05-19 19:56 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1105182019170.20651@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave@linux.vnet.ibm.com \
--cc=dkiper@net-space.pl \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=ian.campbell@citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasik@iki.fi \
--cc=v.tolstov@selfip.ru \
--cc=wdauchy@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox