linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Colin King <colin.king@canonical.com>,
	Raghavendra D Prabhu <raghu.prabhu13@gmail.com>,
	Jan Kara <jack@suse.cz>, Chris Mason <chris.mason@oracle.com>,
	Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>, Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/3] mm: slub: Default slub_max_order to 0
Date: Tue, 17 May 2011 12:25:39 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1105171220400.5438@chino.kir.corp.google.com> (raw)
In-Reply-To: <20110517094845.GK5279@suse.de>

On Tue, 17 May 2011, Mel Gorman wrote:

> > The fragmentation isn't the only issue with the netperf TCP_RR benchmark, 
> > the problem is that the slub slowpath is being used >95% of the time on 
> > every allocation and free for the very large number of kmalloc-256 and 
> > kmalloc-2K caches. 
> 
> Ok, that makes sense as I'd full expect that benchmark to exhaust
> the per-cpu page (high order or otherwise) of slab objects routinely
> during default and I'd also expect the freeing on the other side to
> be releasing slabs frequently to the partial or empty lists.
> 

That's most of the problem, but it's compounded on this benchmark because 
the slab pulled from the partial list to replace the per-cpu page 
typically only has a very minimal number (2 or 3) of free objects, so it 
can only serve one allocation and then require the allocation slowpath to 
pull yet another slab from the partial list the next time around.  I had a 
patchset that addressed that, which I called "slab thrashing", by only 
pulling a slab from the partial list when it had a pre-defined proportion 
of available objects and otherwise skipping it, and that ended up helping 
the benchmark by 5-7%.  Smaller orders will make this worse, as well, 
since if there were only 2 or 3 free objects on an order-3 slab before, 
there's no chance that's going to be equivalent on an order-0 slab.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-05-17 19:26 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 15:29 [PATCH 0/3] Reduce impact to overall system of SLUB using high-order allocations Mel Gorman
2011-05-11 15:29 ` [PATCH 1/3] mm: slub: Do not wake kswapd for SLUBs speculative " Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 15:29 ` [PATCH 2/3] mm: slub: Do not take expensive steps " Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 21:10     ` Mel Gorman
2011-05-12 17:25       ` Andrea Arcangeli
2011-05-11 15:29 ` [PATCH 3/3] mm: slub: Default slub_max_order to 0 Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 20:53     ` James Bottomley
2011-05-11 21:09     ` Mel Gorman
2011-05-11 22:27       ` David Rientjes
2011-05-13 10:14         ` Mel Gorman
2011-05-12 17:36     ` Andrea Arcangeli
2011-05-16 21:03       ` David Rientjes
2011-05-17  9:48         ` Mel Gorman
2011-05-17 19:25           ` David Rientjes [this message]
2011-05-12 14:43   ` Christoph Lameter
2011-05-12 15:15     ` James Bottomley
2011-05-12 15:27       ` Christoph Lameter
2011-05-12 15:43         ` James Bottomley
2011-05-12 15:46           ` Dave Jones
2011-05-12 16:00             ` James Bottomley
2011-05-12 16:08               ` Dave Jones
2011-05-12 16:27               ` Christoph Lameter
2011-05-12 16:30                 ` James Bottomley
2011-05-12 16:48                   ` Christoph Lameter
2011-05-12 17:46                     ` Andrea Arcangeli
2011-05-12 18:00                       ` Christoph Lameter
2011-05-12 18:18                         ` Andrea Arcangeli
2011-05-12 17:06                   ` Pekka Enberg
2011-05-12 17:11                     ` Pekka Enberg
2011-05-12 17:38                       ` Christoph Lameter
2011-05-12 18:00                         ` Andrea Arcangeli
2011-05-13  9:49                           ` Mel Gorman
2011-05-15 16:39                             ` Andrea Arcangeli
2011-05-16  8:42                               ` Mel Gorman
2011-05-12 17:51                       ` Andrea Arcangeli
2011-05-12 18:03                         ` Christoph Lameter
2011-05-12 18:09                           ` Andrea Arcangeli
2011-05-12 18:16                             ` Christoph Lameter
2011-05-12 18:36                       ` James Bottomley
2011-05-12 17:40                 ` Andrea Arcangeli
2011-05-12 15:55           ` Pekka Enberg
2011-05-12 18:37             ` James Bottomley
2011-05-12 18:46               ` Christoph Lameter
2011-05-12 19:21                 ` James Bottomley
2011-05-12 19:44               ` James Bottomley
2011-05-12 20:04                 ` James Bottomley
2011-05-12 20:29                   ` Johannes Weiner
2011-05-12 20:31                     ` Johannes Weiner
2011-05-12 20:31                     ` James Bottomley
2011-05-12 22:04                   ` James Bottomley
2011-05-12 22:15                     ` Johannes Weiner
2011-05-12 22:58                       ` Minchan Kim
2011-05-13  5:39                         ` Minchan Kim
2011-05-13  0:47                       ` James Bottomley
2011-05-13  4:12                         ` James Bottomley
2011-05-13 10:55                         ` Mel Gorman
2011-05-13 14:16                           ` James Bottomley
2011-05-13 10:30                       ` Mel Gorman
2011-05-13  6:16                   ` Pekka Enberg
2011-05-13 10:05                     ` Mel Gorman
2011-05-12 16:01           ` Christoph Lameter
2011-05-12 16:10             ` Eric Dumazet
2011-05-12 17:37               ` Andrew Morton
2011-05-12 15:45         ` Dave Jones
2011-05-11 21:39 ` [PATCH 0/3] Reduce impact to overall system of SLUB using high-order allocations James Bottomley
2011-05-11 22:28   ` David Rientjes
2011-05-11 22:34     ` James Bottomley
2011-05-12 11:13       ` Pekka Enberg
2011-05-12 13:19         ` Mel Gorman
2011-05-12 14:04         ` James Bottomley
2011-05-12 15:53           ` James Bottomley
2011-05-13 11:25             ` Mel Gorman
2011-05-12 18:04       ` Andrea Arcangeli
2011-05-13 11:24         ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1105171220400.5438@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=cl@linux.com \
    --cc=colin.king@canonical.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=penberg@kernel.org \
    --cc=raghu.prabhu13@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox