From: David Rientjes <rientjes@google.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>, linux-mm@kvack.org
Subject: Re: [Slub cleanup6 2/5] slub: get_map() function to establish map of free objects in a slab
Date: Thu, 12 May 2011 13:01:42 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1105121301280.2407@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1105121140510.27324@router.home>
On Thu, 12 May 2011, Christoph Lameter wrote:
> Subject: slub: Avoid warning for !CONFIG_SLUB_DEBUG
>
> Move the #ifdef so that get_map is only defined if CONFIG_SLUB_DEBUG is defined.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>
Acked-by: David Rientjes <rientjes@google.com>
>
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/mm/slub.c
> ===================================================================
> --- linux-2.6.orig/mm/slub.c 2011-05-12 11:38:42.000000000 -0500
> +++ linux-2.6/mm/slub.c 2011-05-12 11:39:40.000000000 -0500
> @@ -326,6 +326,7 @@ static inline int oo_objects(struct kmem
> return x.x & OO_MASK;
> }
>
> +#ifdef CONFIG_SLUB_DEBUG
> /*
> * Determine a map of object in use on a page.
> *
> @@ -341,7 +342,6 @@ static void get_map(struct kmem_cache *s
> set_bit(slab_index(p, s, addr), map);
> }
>
> -#ifdef CONFIG_SLUB_DEBUG
> /*
> * Debug settings:
> */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-12 20:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 19:48 [Slub cleanup6 0/5] SLUB: Cleanups V6 Christoph Lameter
2011-04-15 19:48 ` [Slub cleanup6 1/5] slub: Use NUMA_NO_NODE in get_partial Christoph Lameter
2011-05-11 20:03 ` David Rientjes
2011-04-15 19:48 ` [Slub cleanup6 2/5] slub: get_map() function to establish map of free objects in a slab Christoph Lameter
2011-05-11 20:03 ` David Rientjes
2011-05-12 16:41 ` Christoph Lameter
2011-05-12 20:01 ` David Rientjes [this message]
2011-04-15 19:48 ` [Slub cleanup6 3/5] slub: Eliminate repeated use of c->page through a new page variable Christoph Lameter
2011-05-11 20:03 ` David Rientjes
2011-04-15 19:48 ` [Slub cleanup6 4/5] slub: Move node determination out of hotpath Christoph Lameter
2011-05-11 20:03 ` David Rientjes
2011-05-12 16:44 ` Christoph Lameter
2011-05-12 20:10 ` [patch] slub: avoid label inside conditional David Rientjes
2011-05-13 14:49 ` Christoph Lameter
2011-04-15 19:48 ` [Slub cleanup6 5/5] slub: Move debug handlign in __slab_free Christoph Lameter
2011-05-11 20:03 ` David Rientjes
2011-04-17 11:05 ` [Slub cleanup6 0/5] SLUB: Cleanups V6 Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1105121301280.2407@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox