From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 1CA06900001 for ; Thu, 12 May 2011 14:00:23 -0400 (EDT) Date: Thu, 12 May 2011 13:00:10 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH 3/3] mm: slub: Default slub_max_order to 0 In-Reply-To: <20110512174641.GL11579@random.random> Message-ID: References: <1305127773-10570-4-git-send-email-mgorman@suse.de> <1305213359.2575.46.camel@mulgrave.site> <1305214993.2575.50.camel@mulgrave.site> <20110512154649.GB4559@redhat.com> <1305216023.2575.54.camel@mulgrave.site> <1305217843.2575.57.camel@mulgrave.site> <20110512174641.GL11579@random.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: James Bottomley , Dave Jones , Mel Gorman , Andrew Morton , Colin King , Raghavendra D Prabhu , Jan Kara , Chris Mason , Pekka Enberg , Rik van Riel , Johannes Weiner , linux-fsdevel , linux-mm , linux-kernel , linux-ext4 On Thu, 12 May 2011, Andrea Arcangeli wrote: > order 1 should work better, because it's less likely we end up here > (which leaves RECLAIM_MODE_LUMPYRECLAIM on and then see what happens > at the top of page_check_references()) > > else if (sc->order && priority < DEF_PRIORITY - 2) Why is this DEF_PRIORITY - 2? Shouldnt it be DEF_PRIORITY? An accomodation for SLAB order 1 allocs? May I assume that the case of order 2 and 3 allocs in that case was not very well tested after the changes to introduce compaction since people were focusing on RHEL testing? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org