From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 22DA76B0012 for ; Wed, 11 May 2011 16:34:10 -0400 (EDT) Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id p4BKY8fL026054 for ; Wed, 11 May 2011 13:34:08 -0700 Received: from pwj8 (pwj8.prod.google.com [10.241.219.72]) by wpaz33.hot.corp.google.com with ESMTP id p4BKXsGT022772 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 11 May 2011 13:34:07 -0700 Received: by pwj8 with SMTP id 8so516523pwj.41 for ; Wed, 11 May 2011 13:34:03 -0700 (PDT) Date: Wed, 11 May 2011 13:34:01 -0700 (PDT) From: David Rientjes Subject: Re: OOM Killer don't works at all if the system have >gigabytes memory (was Re: [PATCH] mm: check zone->all_unreclaimable in all_unreclaimable()) In-Reply-To: <1889981320.330808.1305081044822.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> Message-ID: References: <1889981320.330808.1305081044822.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: CAI Qian Cc: KOSAKI Motohiro , avagin@gmail.com, Andrey Vagin , Andrew Morton , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , Hugh Dickins , Oleg Nesterov On Tue, 10 May 2011, CAI Qian wrote: > Sure, I saw there were some discussion going on between you and David > about your patches. Does it make more sense for me to test those after > you have settled down technical arguments? > Something like the following (untested) patch should fix the issue by simply increasing the range of a task's badness from 0-1000 to 0-10000. There are other things to fix like the tasklist dump output and documentation, but this shows how easy it is to increase the resolution of the scoring. (This patch also includes a change to only give root processes a 1% bonus for every 30% of memory they use as proposed earlier.) diff --git a/mm/oom_kill.c b/mm/oom_kill.c --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -160,7 +160,7 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem, */ if (p->flags & PF_OOM_ORIGIN) { task_unlock(p); - return 1000; + return 10000; } /* @@ -177,32 +177,32 @@ unsigned int oom_badness(struct task_struct *p, struct mem_cgroup *mem, points = get_mm_rss(p->mm) + p->mm->nr_ptes; points += get_mm_counter(p->mm, MM_SWAPENTS); - points *= 1000; + points *= 10000; points /= totalpages; task_unlock(p); /* - * Root processes get 3% bonus, just like the __vm_enough_memory() - * implementation used by LSMs. + * Root processes get 1% bonus per 30% memory used for a total of 3% + * possible just like LSMs. */ if (has_capability_noaudit(p, CAP_SYS_ADMIN)) - points -= 30; + points -= 100 * (points / 3000); /* * /proc/pid/oom_score_adj ranges from -1000 to +1000 such that it may * either completely disable oom killing or always prefer a certain * task. */ - points += p->signal->oom_score_adj; + points += p->signal->oom_score_adj * 10; /* * Never return 0 for an eligible task that may be killed since it's - * possible that no single user task uses more than 0.1% of memory and + * possible that no single user task uses more than 0.01% of memory and * no single admin tasks uses more than 3.0%. */ if (points <= 0) return 1; - return (points < 1000) ? points : 1000; + return (points < 10000) ? points : 10000; } /* @@ -314,7 +314,7 @@ static struct task_struct *select_bad_process(unsigned int *ppoints, */ if (p == current) { chosen = p; - *ppoints = 1000; + *ppoints = 10000; } else { /* * If this task is not being ptraced on exit, -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org