linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
	Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [patch] mm: always set nodes with regular memory in N_NORMAL_MEMORY
Date: Thu, 21 Apr 2011 14:41:28 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1104211440240.20201@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1104211411540.20201@chino.kir.corp.google.com>

N_NORMAL_MEMORY is intended to include all nodes that have present memory 
in regular zones, that is, zones below ZONE_HIGHMEM.  This should be done 
regardless of whether CONFIG_HIGHMEM is set or not.

This fixes ia64 so that the nodes get set appropriately in the nodemask 
for DISCONTIGMEM and mips if it does not enable CONFIG_HIGHMEM even for 
32-bit kernels.

If N_NORMAL_MEMORY is not accurate, slub may encounter errors since it 
relies on this nodemask to setup kmem_cache_node data structures for each 
cache.

Signed-off-by: David Rientjes <rientjes@google.com>
---
 mm/page_alloc.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4727,7 +4727,6 @@ out:
 /* Any regular memory on that node ? */
 static void check_for_regular_memory(pg_data_t *pgdat)
 {
-#ifdef CONFIG_HIGHMEM
 	enum zone_type zone_type;
 
 	for (zone_type = 0; zone_type <= ZONE_NORMAL; zone_type++) {
@@ -4735,7 +4734,6 @@ static void check_for_regular_memory(pg_data_t *pgdat)
 		if (zone->present_pages)
 			node_set_state(zone_to_nid(zone), N_NORMAL_MEMORY);
 	}
-#endif
 }
 
 /**

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-04-21 21:41 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 13:51 [PATCH] mm: make expand_downwards symmetrical to expand_upwards Michal Hocko
2011-04-18  3:00 ` Hugh Dickins
2011-04-18 10:01   ` [PATCH v2] " Michal Hocko
2011-04-18 20:56     ` Andrew Morton
     [not found]       ` <20110419091022.GA21689@tiehlicka.suse.cz>
2011-04-19 11:09         ` [PATCH followup] mm: get rid of CONFIG_STACK_GROWSUP || CONFIG_IA64 Michal Hocko
2011-04-20  0:33           ` KOSAKI Motohiro
2011-04-20  6:59             ` Michal Hocko
2011-04-20  7:08               ` KOSAKI Motohiro
2011-04-26  7:59           ` Michal Hocko
2011-04-19 11:10       ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards Michal Hocko
2011-04-19 15:46         ` James Bottomley
2011-04-19 16:06           ` [PATCH v3] mm: make expand_downwards symmetrical to John David Anglin
2011-04-19 16:59             ` James Bottomley
2011-04-19 16:07           ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards James Bottomley
2011-04-19 17:05           ` Pekka Enberg
2011-04-19 17:11             ` James Bottomley
2011-04-19 17:15               ` Christoph Lameter
2011-04-19 17:48                 ` James Bottomley
2011-04-19 18:10                   ` Christoph Lameter
2011-04-19 18:20                     ` James Bottomley
2011-04-19 18:35                       ` Christoph Lameter
2011-04-19 19:49                         ` James Bottomley
2011-04-19 20:56                           ` Christoph Lameter
2011-04-19 21:21                             ` James Bottomley
2011-04-19 21:39                               ` Christoph Lameter
2011-04-19 21:48                                 ` James Bottomley
2011-04-19 21:58                                   ` Christoph Lameter
2011-04-20  1:23                                     ` KOSAKI Motohiro
2011-04-20  2:48                                       ` James Bottomley
2011-04-20  2:57                                         ` KOSAKI Motohiro
2011-04-20 13:50                                           ` Christoph Lameter
2011-04-21 13:32                                             ` Tejun Heo
2011-04-20  5:53                                       ` Pekka Enberg
2011-04-20  7:15                                         ` KOSAKI Motohiro
2011-04-20  7:34                                           ` Pekka Enberg
2011-04-20  8:40                                             ` KOSAKI Motohiro
2011-04-20 16:32                                               ` James Bottomley
2011-04-20 16:50                                                 ` Christoph Lameter
2011-04-20 18:09                                                   ` James Bottomley
2011-04-20 21:18                                                 ` David Rientjes
2011-04-20 22:15                                                   ` James Bottomley
2011-04-20 23:12                                                     ` David Rientjes
2011-04-21 13:16                                                       ` KOSAKI Motohiro
2011-04-21 16:37                                                         ` James Bottomley
2011-04-21 18:33                                                           ` Christoph Lameter
2011-04-21 18:45                                                             ` Dave Hansen
2011-04-22 18:19                                                               ` James Bottomley
2011-04-22 20:24                                                                 ` Dave Hansen
2011-04-22 20:35                                                                   ` James Bottomley
2011-04-22 21:33                                                               ` James Bottomley
2011-04-23 18:34                                                                 ` [PATCH] convert parisc to sparsemem (was Re: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards) James Bottomley
2011-04-24 16:27                                                                   ` John David Anglin
2011-04-26  0:32                                                                   ` KOSAKI Motohiro
2011-04-27 16:36                                                                   ` Dave Hansen
2011-04-21 20:05                                                             ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards James Bottomley
2011-04-21 21:07                                                               ` Christoph Lameter
2011-04-21 21:22                                                                 ` James Bottomley
2011-04-21 19:33                                                         ` David Rientjes
2011-04-22  0:34                                                           ` KOSAKI Motohiro
2011-04-21 13:03                                                   ` KOSAKI Motohiro
2011-04-21 19:38                                                     ` David Rientjes
2011-04-21 20:02                                                       ` Christoph Lameter
2011-04-21 21:19                                                         ` David Rientjes
2011-04-21 21:24                                                           ` James Bottomley
2011-04-21 21:34                                                             ` David Rientjes
2011-04-21 21:49                                                               ` James Bottomley
2011-04-21 22:12                                                                 ` David Rientjes
2011-04-22  8:02                                                                   ` Pekka Enberg
2011-04-22 13:49                                                                     ` James Bottomley
2011-04-22 17:00                                                                       ` Pekka Enberg
2011-04-22 17:03                                                                         ` James Bottomley
2011-04-21 21:41                                                           ` David Rientjes [this message]
2011-04-22  0:36                                                             ` [patch] mm: always set nodes with regular memory in N_NORMAL_MEMORY KOSAKI Motohiro
2011-04-20 21:05                                               ` [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards David Rientjes
2011-04-20 11:20                                             ` Matthew Wilcox
2011-04-20 11:28                                               ` Pekka Enberg
2011-04-20 14:15                                                 ` James Bottomley
2011-04-20 14:50                                                   ` Christoph Lameter
2011-04-20 15:02                                                     ` James Bottomley
2011-04-20 15:22                                                       ` Christoph Lameter
2011-04-20 19:25                                                         ` Matthew Wilcox
2011-04-20 21:42                                                         ` David Rientjes
2011-04-21 16:06                                                           ` James Bottomley
2011-04-21 22:19                                                             ` David Rientjes
2011-04-21 22:31                                                               ` James Bottomley
2011-04-20 13:58                                               ` Christoph Lameter
2011-04-20 21:34                                               ` David Rientjes
2011-04-20 14:07                                             ` Christoph Lameter
2011-04-20  2:33                                     ` James Bottomley
2011-04-19 17:12             ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1104211440240.20201@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=Lee.Schermerhorn@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox