From: Christoph Lameter <cl@linux.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
"hugh.dickins@tiscali.co.uk" <hugh.dickins@tiscali.co.uk>,
Parisc List <linux-parisc@vger.kernel.org>
Subject: Re: slub: fix panic with DISCONTIGMEM
Date: Tue, 19 Apr 2011 17:04:31 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1104191702400.26867@router.home> (raw)
In-Reply-To: <1303249970.11237.30.camel@mulgrave.site>
On Tue, 19 Apr 2011, James Bottomley wrote:
> On Tue, 2011-04-19 at 16:38 -0500, Christoph Lameter wrote:
> > On Tue, 19 Apr 2011, James Bottomley wrote:
> >
> > > Slub makes assumptions about page_to_nid() which are violated by
> > > DISCONTIGMEM and !NUMA. This violation results in a panic because
> >
> > Fix this by stating correctly by saying "The kernel makes assumptions in
> > various subsystems ..."
>
> Slub is a subset of the kernel, so the original wording is a bit more
> precise.
F.e. hugepage support does the same thing. So it not slub specific.
> Well, we can discuss how to proceed going forwards. The current fact is
> that any prior kernel that enables SLUB with DISCONTIGMEM and !NUMA will
> eventually go boom when the page allocator returns a page not in the
> first pfn array. That has to be fixed in -stable. I don't really think
> a DISCONTIGMEM re-engineering effort would be the best thing for the
> -stable series.
As far as I can tell: It will go boom even with other subsystems. I am
surprised that we have never seen this before.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-04-19 22:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1303248576.11237.23.camel@mulgrave.site>
[not found] ` <alpine.DEB.2.00.1104191633250.23077@router.home>
2011-04-19 21:52 ` James Bottomley
2011-04-19 22:04 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1104191702400.26867@router.home \
--to=cl@linux.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox