From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Jack Steiner <steiner@sgi.com>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Paul Menage <menage@google.com>, Robin Holt <holt@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH v2] cpusets: randomize node rotor used in cpuset_mem_spread_node()
Date: Fri, 15 Apr 2011 16:42:13 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1104151639080.3967@chino.kir.corp.google.com> (raw)
In-Reply-To: <20110415082051.GB8828@tiehlicka.suse.cz>
On Fri, 15 Apr 2011, Michal Hocko wrote:
> You are right. I was thinking about lazy approach and initialize those
> values when they are used for the first time. What about the patch
> below?
>
> Change from v1:
> - initialize cpuset_{mem,slab}_spread_rotor lazily
>
The difference between this v2 patch and what is already in the -mm tree
(http://userweb.kernel.org/~akpm/mmotm/broken-out/cpusets-randomize-node-rotor-used-in-cpuset_mem_spread_node.patch)
is the lazy initialization by adding cpuset_{mem,slab}_spread_node()?
It'd probably be better to just make an incremental patch on top of
mmotm-2011-04-14-15-08 with a new changelog and then propose with with
your list of reviewed-by lines.
Andrew could easily drop the earlier version and merge this v2, but I'm
asking for selfish reasons: please use NUMA_NO_NODE instead of -1.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-15 23:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110414065146.GA19685@tiehlicka.suse.cz>
[not found] ` <20110414160145.0830.A69D9226@jp.fujitsu.com>
[not found] ` <20110415161831.12F8.A69D9226@jp.fujitsu.com>
2011-04-15 8:20 ` Michal Hocko
2011-04-15 8:29 ` KOSAKI Motohiro
2011-04-15 8:31 ` Michal Hocko
2011-04-15 23:42 ` David Rientjes [this message]
2011-04-18 8:42 ` [PATCH incremental] cpusets: initialize spread rotor lazily Michal Hocko
2011-04-18 20:19 ` David Rientjes
2011-04-18 21:29 ` Michal Hocko
2011-04-19 1:15 ` David Rientjes
2011-05-26 22:33 ` [PATCH v2] cpusets: randomize node rotor used in cpuset_mem_spread_node() Andrew Morton
2011-05-27 12:47 ` Michal Hocko
2011-05-27 19:07 ` David Rientjes
2011-05-27 23:17 ` Michal Hocko
2011-05-27 23:27 ` David Rientjes
2011-05-27 23:40 ` Michal Hocko
2011-05-27 21:20 ` Andrew Morton
2011-05-27 23:17 ` Michal Hocko
2011-05-27 23:30 ` David Rientjes
2011-05-27 23:38 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1104151639080.3967@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=holt@sgi.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=mhocko@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=steiner@sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox