From: Christoph Lameter <cl@linux.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: akpm@linux-foundation.org, aarcange@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: make read-only accessors take const parameters
Date: Fri, 15 Apr 2011 09:51:18 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1104150949210.5863@router.home> (raw)
In-Reply-To: <1302861377-8048-2-git-send-email-ext-phil.2.carmody@nokia.com>
On Fri, 15 Apr 2011, Phil Carmody wrote:
> +++ b/include/linux/mm.h
> @@ -353,9 +353,16 @@ static inline struct page *compound_head(struct page *page)
> return page;
> }
>
> -static inline int page_count(struct page *page)
> +static inline const struct page *compound_head_ro(const struct page *page)
> {
> - return atomic_read(&compound_head(page)->_count);
> + if (unlikely(PageTail(page)))
> + return page->first_page;
> + return page;
> +}
Can you make compound_head take a const pointer too to avoid this?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-15 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 9:56 [PATCH 0/1] mm: make read-only accessors take const pointer parameters Phil Carmody
2011-04-15 9:56 ` [PATCH] mm: make read-only accessors take const parameters Phil Carmody
2011-04-15 14:51 ` Christoph Lameter [this message]
2011-04-15 16:07 ` Phil Carmody
2011-04-20 11:45 ` Artem Bityutskiy
2011-04-16 23:48 ` David Rientjes
2011-04-15 14:51 ` [PATCH 0/1] mm: make read-only accessors take const pointer parameters Andrea Arcangeli
2011-04-15 15:59 ` Phil Carmody
2011-04-15 16:09 ` Andrea Arcangeli
2011-04-20 9:28 ` Artem Bityutskiy
2011-04-20 11:20 ` Michal Nazarewicz
2011-04-20 11:44 ` Artem Bityutskiy
2011-04-15 16:12 ` Michal Nazarewicz
2011-04-15 16:28 ` Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1104150949210.5863@router.home \
--to=cl@linux.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox