From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: NeilBrown <neilb@suse.de>, Ben Hutchings <ben@decadent.org.uk>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>,
Johannes Weiner <jweiner@redhat.com>,
Rik van Riel <riel@redhat.com>, Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm/thp: Use conventional format for boolean attributes
Date: Thu, 14 Apr 2011 12:50:58 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1104141250360.20747@chino.kir.corp.google.com> (raw)
In-Reply-To: <20110414120920.1e6c04ff.akpm@linux-foundation.org>
On Thu, 14 Apr 2011, Andrew Morton wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
>
> The conventional format for boolean attributes in sysfs is numeric ("0" or
> "1" followed by new-line). Any boolean attribute can then be read and
> written using a generic function. Using the strings "yes [no]", "[yes]
> no" (read), "yes" and "no" (write) will frustrate this.
>
> [akpm@linux-foundation.org: use kstrtoul()]
> [akpm@linux-foundation.org: test_bit() doesn't return 1/0, per Neil]
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Mel Gorman <mel@csn.ul.ie>
> Cc: Johannes Weiner <jweiner@redhat.com>
> Cc: Rik van Riel <riel@redhat.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: David Rientjes <rientjes@google.com>
> Cc: NeilBrown <neilb@suse.de>
> Cc: <stable@kernel.org> [2.6.38.x]
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Tested-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-14 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 5:45 Ben Hutchings
2011-04-13 19:04 ` David Rientjes
2011-04-13 19:19 ` Andrew Morton
2011-04-13 19:28 ` David Rientjes
2011-04-13 19:35 ` Andrea Arcangeli
2011-04-14 4:48 ` NeilBrown
2011-04-14 14:29 ` Andrea Arcangeli
2011-04-14 16:57 ` Ben Hutchings
2011-04-14 19:09 ` Andrew Morton
2011-04-14 19:50 ` David Rientjes [this message]
2011-04-13 19:31 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1104141250360.20747@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ben@decadent.org.uk \
--cc=hughd@google.com \
--cc=jweiner@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=neilb@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox