linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: David Rientjes <rientjes@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] slub: Fix a typo in config name
Date: Wed, 13 Apr 2011 08:36:25 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.1104130835360.16214@router.home> (raw)
In-Reply-To: <alpine.DEB.2.00.1104121913410.15979@chino.kir.corp.google.com>

On Tue, 12 Apr 2011, David Rientjes wrote:

> On Tue, 12 Apr 2011, Christoph Lameter wrote:
>
> > On Tue, 12 Apr 2011, Li Zefan wrote:
> >
> > > There's no config named SLAB_DEBUG, and it should be a typo
> > > of SLUB_DEBUG.
> > >
> > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > > ---
> > >
> > > not slub expert, don't know how this bug affects slub debugging.
> >
> > Affects the bootstrap code.
> >
>
> I don't see how, there should be no partial or full slabs for either
> kmem_cache or kmem_cache_node at this point in the boot sequence.  I think
> kmem_cache_bootstrap_fixup() should only need to add the cache to the list
> of slab caches and set the refcount accordingly.

Hmmm... That depends on the number of objects in a slab page. If that is
one then we may have an issue.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2011-04-13 13:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  7:22 Li Zefan
2011-04-12 18:02 ` Christoph Lameter
2011-04-13  2:16   ` David Rientjes
2011-04-13 13:36     ` Christoph Lameter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.1104130835360.16214@router.home \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox