From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 1CA2A8D0040 for ; Thu, 24 Mar 2011 15:05:57 -0400 (EDT) Date: Thu, 24 Mar 2011 14:05:51 -0500 (CDT) From: Christoph Lameter Subject: Re: [GIT PULL] SLAB changes for v2.6.39-rc1 In-Reply-To: Message-ID: References: <20110324172653.GA28507@elte.hu> <1300990853.3747.189.camel@edumazet-laptop> <20110324185903.GA30510@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Ingo Molnar , Eric Dumazet , torvalds@linux-foundation.org, akpm@linux-foundation.org, tj@kernel.org, npiggin@kernel.dk, rientjes@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org On Thu, 24 Mar 2011, Pekka Enberg wrote: > It hanged here which is pretty much expected on this box if > kmem_cache_init() oopses. I'm now trying to see if I'm able to find > the config option that breaks things. CONFIG_PREEMPT_NONE is a > suspect: > > penberg@tiger:~/linux$ grep PREEMPT ../config-ingo > # CONFIG_PREEMPT_RCU is not set > CONFIG_PREEMPT_NONE=y > # CONFIG_PREEMPT_VOLUNTARY is not set > # CONFIG_PREEMPT is not set The following patch should ensure that all percpu data is touched before any emulation functions are called: --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c 2011-03-24 14:03:10.000000000 -0500 +++ linux-2.6/mm/slub.c 2011-03-24 14:04:08.000000000 -0500 @@ -1604,7 +1604,7 @@ static inline void note_cmpxchg_failure( void init_kmem_cache_cpus(struct kmem_cache *s) { -#if defined(CONFIG_CMPXCHG_LOCAL) && defined(CONFIG_PREEMPT) +#ifdef CONFIG_CMPXCHG_LOCAL int cpu; for_each_possible_cpu(cpu) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org